fix: the dialog name does not update in the navigation pane when changed in the properties panel #6393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
lei9444
changed the title
cwhitten
approved these changes
Mar 12, 2021
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…ged in the properties panel (microsoft#6393) * fix: the dialog name does not update in the navigation pane when changed in the properties panel * update empty deisgner name * fix click show error * update the name function * fix dialog displayname
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Root cause
The form editor and breadscrum only use the $designer.name to show the label. The project Tree will use $designer.name and dialog.id to show the item label. So when the name is undefined, the display name will be different.
fix
label = $designer.name ?? dialog.id
Task Item
closes #6387
closes #6375
Screenshots