Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add delete button for publish targets #6557

Merged
merged 12 commits into from
Mar 25, 2021
Merged

Conversation

GeoffCoxMSFT
Copy link
Member

@GeoffCoxMSFT GeoffCoxMSFT commented Mar 25, 2021

Description

Add the delete button to the publish targets listed on the settings page.
Includes a confirmation prompt.

Task Item

closes #5642

Screenshots

image

image

benbrown
benbrown previously approved these changes Mar 25, 2021
@GeoffCoxMSFT GeoffCoxMSFT dismissed stale reviews from hatpick and benbrown via b437e6d March 25, 2021 17:28
hatpick
hatpick previously approved these changes Mar 25, 2021
@coveralls
Copy link

coveralls commented Mar 25, 2021

Coverage Status

Coverage decreased (-0.02%) to 52.314% when pulling 24f113a on gcox/fix5642 into 847a842 on main.

@GeoffCoxMSFT GeoffCoxMSFT merged commit 0ac0af8 into main Mar 25, 2021
@GeoffCoxMSFT GeoffCoxMSFT deleted the gcox/fix5642 branch March 25, 2021 21:14
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* Added delete action to list of publish targets

* Updated string to avoid extra quotes

* Removed the non-useful useCallback

* Remove import of useCallback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't Delete Publish Target
4 participants