Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installer launches directly into emulator #1259

Closed
dkisselev opened this issue Jan 28, 2019 · 9 comments · Fixed by #2077
Closed

Windows installer launches directly into emulator #1259

dkisselev opened this issue Jan 28, 2019 · 9 comments · Fixed by #2077
Assignees

Comments

@dkisselev
Copy link

dkisselev commented Jan 28, 2019

Version

4.2.1

Describe the bug

When installing the emulator on Windows, the installer shows the progress bar, then disappears and immediately launches the emulator.

This behavior is not typical for windows installers and disorienting as the new emulator window appears above anything else the user is working on.

Most installers show a final page with a "Finish" button and a checkbox (checked by default) to confirm whether the user wants to run the software right away.

To Reproduce

Steps to reproduce the behavior:

  1. Download and run BotFramework-Emulator-4.2.1-windows-setup.exe
  2. Proceed through the first few prompts until the installer progress bar starts working
  3. Change windows to any other open app (optional)
  4. Observe that the installer closes itself without any warning and the emulator appears above all other work (stealing context).

Expected behavior

When install progress is finished, the installer should stay in the background, show a final confirmation page that offers the option to open the emulator, and flash a taskbar notification to alert the user that it's finished.

[bug]

@tonyanziano
Copy link
Contributor

tonyanziano commented Jan 28, 2019

We can try this out and see how it feels. It should be as easy as flipping the oneClick property in the build config to false.

(Source)

@dkisselev
Copy link
Author

dkisselev commented Jan 28, 2019

Just to clarify,

I'm not trying to suggest whether or not showing the wizard is necessary (or if a silent/one-click install option would be better),

But if the installer shows a wizard (and that's deemed the best way forward for the project), then the wizard should show a final confirmation page before it launches a new program that steals context.

@DesignPolice
Copy link

@tonyanziano sounds like fun... I will be back in the morning we can chat about this.

@tonyanziano
Copy link
Contributor

@DesignPolice Sure, I can give you the expected dimensions of the graphics and show you what it's supposed to look like.

However, we should first test the auto update experience without a silent launcher to see what the behavior is like.

@DesignPolice
Copy link

digging through my # tags - @tonyanziano are we still tracking visuals for this? thanks m

@tonyanziano
Copy link
Contributor

@DesignPolice this is on the backlog for now. If I get some cycles, I'll try out the auto update experience without a silent installer, and then we can go from there.

@DesignPolice
Copy link

@tonyanziano Happy New Year.. Chris tagged me on this, does that mean it is off backlog. hehe - I have some bandwidth

@tonyanziano
Copy link
Contributor

@DesignPolice Happy New Year to you! I have yet to take a look at this because I still need to button up what I was working on before I left for the holidays. I'll get back to you.

@DesignPolice
Copy link

ok cool, I will be in the office tomorrow... if that helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants