-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View menu text scrub #1053
View menu text scrub #1053
Conversation
Pull Request Test Coverage Report for Build 1145
💛 - Coveralls |
@@ -235,16 +235,7 @@ export const AppMenuBuilder = new class AppMenuBuilderImpl implements AppMenuBui | |||
return { | |||
label: 'View', | |||
submenu: [ | |||
{ | |||
label: 'Explorer', | |||
click: () => mainWindow.commandService.remoteCall(SharedConstants.Commands.UI.ShowExplorer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any more calls to these commands? If not, let's remove the command registrations too.
@@ -3,20 +3,20 @@ | |||
object-assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did this get in there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diff was showing up for me as well every time I pulled and rebuilt the package, but I never checked it in. This must be that same change. I have no idea how it gets generated though.
Also, once you resolve all the changes you might want to re-submit this PR into |
@tonyanziano @justinwilaby Thanks guys, let me redo this PR with corrections. :) |
Closing this in favor of #1061 |
Resolves #820
(Low priority PR as this is a 4.2 change)