Ngrok Status Viewer UI Updates #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 24, 2020 12:45
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Stable commit to be refactored Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> safe ngrok status viewer display Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Last ping interval set Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Ngrok tab updated Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Tunnel classes updated Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Stable ngrok tests Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Fetch with timeout updated Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Reducer specs updated Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Ngrok tunnel action test updated Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> All tests on client and main pass Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Removed ngrok notification icon Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> ngrok tab test Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Code review cleanup Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Safe commit for tracking notifications Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Lock updated Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Saga update Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Clearning notifications when status shifts from error to Active Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Tests and copy working Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Moved check for reporting upto ngrok Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Using status instead status code Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> TEst build Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Package json updated Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Tests completed Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Reverted to electron rebuilder to support windows Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Console log removed Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> handling timeouts Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> All tests passing for sagas Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
srinaath
requested review from
cwhitten,
compulim,
tonyanziano,
a-b-r-o-w-n,
corinagum and
tdurnford
srinaath
changed the title
srinaath
changed the title
tonyanziano
suggested changes
Jan 28, 2020
packages/app/client/src/ui/editor/appSettingsEditor/appSettingsEditor.tsx
Outdated
Show resolved
Hide resolved
packages/app/client/src/ui/editor/ngrokDebugger/ngrokStatusIndicator.tsx
Show resolved
Hide resolved
added 3 commits
January 28, 2020 07:50
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Added tests fro ngrokCommands Removed comments fixed typos Added high contrast specific var Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
tonyanziano
previously approved these changes
Jan 28, 2020
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
This was referenced Jan 29, 2020
srinaath
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps up all the UX interactions for Ngrok Status Viewer.