Added new telemetry events and properties. #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
srinaath and
tdurnford
as code owners
srinaath
requested changes
Jan 29, 2020
packages/app/client/src/state/sagas/frameworkSettingsSagas.spec.ts
Outdated
Show resolved
Hide resolved
tonyanziano
commented
Jan 29, 2020
| @@ -125,7 +125,7 @@ describe('TelemetryService', () => { | |||
| }); | |||
|
|
|||
| it('should track events', () => { | |||
| Object.assign(global, { __JEST_ENV__: false }); | |||
| global['__JEST_ENV__'] = false; | |||
There was a problem hiding this comment.
I couldn't get spread to work for whatever reason
tonyanziano
force-pushed
the
toanzian/telemetry
branch
from
ee52ca1 to
a91edcc
Compare
srinaath
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2035
===
toolName: 'bf-emulator'to all outgoing events so that we can filter them out from other tools (bf-cli) that use the same Azure Application Insights instancelivechat_openRemoteevent and addedlivechat_openwhich tracks both local and remote URLs being openedsignIn_successandsignIn_failure) into one event (azure_signIn) that now trackssuccessandpersistLoginngrok_reconnect) for when the user reconnects to ngrokapp_changeSetting) that tracks whenever a single or multiple app settings are changed at one timeoauth_sendToken) that tracks when an OAuth flow is completed and a token is sent to the bot