Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] [Screen Reader] Enable the screen reader to announce when nodes are expanded and collapsed in the JSON tree view #2299

Conversation

luislera
Copy link
Contributor

@luislera luislera commented Oct 11, 2021

Fixes ADO Issue: #63920

Describe the issue

If the screen reader is not reading the state as Expanded/Collapsed after selecting the ‘Expand/Collapse’ button present on the ‘JSON’ section under the “Live Chat’ tab, so it would be difficult and confusing for screen reader users to find out the state of the control.

Actual behavior:

The screen reader is not reading the state as Expanded/Collapsed after selecting the ‘Expand/Collapse’ button present on the ‘JSON’ section under the “Live Chat’ tab.

Expected behavior:

The screen reader should be reading the state as Expanded/Collapsed after selecting the ‘Expand/Collapse’ button present on the ‘JSON’ section under the “Live Chat’ tab.

Repro Steps:

  1. Open Bot Framework Emulator installed on the system.
  2. Bot Framework Emulator Application with Welcome screen opens.
  3. Navigate on the welcome screen and select the Open Bot button.
  4. Open A bot Dialog opens, navigate on the dialog and enter inputs in edit fields and select Connect button.
  5. Bot Gets connected and a new Tab opens, navigate to Type a Message field and enter any chat message.
  6. Bot Response as per text entered appears and changes occur in JSON Section.
  7. Navigate on JSON Section.
  8. Verify the issue.

Changes included in the PR

  • Added a DIV element for handling announcements when tree nodes are expanded/collapsed
  • Added a CSS class to position the DIV element offscreen
  • Updated test cases for the Json Viewer component

Screenshots

Test cases executed successfully
imagen

@coveralls
Copy link

coveralls commented Oct 11, 2021

Coverage Status

Coverage increased (+0.03%) to 67.841% when pulling 314cde7 on southworks:external/fix/southworks/fix-collapsed-expanded-announcements into 9a794fb on microsoft:main.

Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor comments.

Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@tonyanziano tonyanziano merged commit ed0b611 into microsoft:main Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants