Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add roles to various components of Web Chat #1462

Merged
merged 9 commits into from
Dec 12, 2018
Merged

Add roles to various components of Web Chat #1462

merged 9 commits into from
Dec 12, 2018

Conversation

corinagum
Copy link
Contributor

@compulim compulim added this to the v4.3 milestone Dec 10, 2018
@compulim compulim added the 4.3 label Dec 10, 2018
@compulim
Copy link
Contributor

Will work on this one after 4.2 release. Hold on.

@coveralls
Copy link

coveralls commented Dec 10, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 589

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.6%) to 44.688%
Files with Coverage Reduction New Missed Lines %
packages/component/src/Utils/TimeAgo.js 3 70.59%
packages/component/src/Utils/Timer.js 6 33.33%
Totals Coverage Status
Change from base Build 584: -0.6%
Covered Lines: 715
Relevant Lines: 1426
💛 - Coveralls

@corinagum corinagum merged commit 06ce298 into microsoft:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@corinagum @compulim @coveralls