Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix send typing #1541

Merged
merged 12 commits into from
Jan 16, 2019
Merged

Fix send typing #1541

merged 12 commits into from
Jan 16, 2019

Conversation

compulim
Copy link
Contributor

Fix #1539

Background

Send typing was not working because:

  • We didn't read initial sendTyping props correctly
    • Missing sendTyping reducer
  • We didn't clear out typing activity correctly
    • Should not add self typing activity
    • Should use takeEvery instead of takeLatest

Also added a sample to show the send typing behavior.

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. 4.3 labels Dec 24, 2018
@compulim compulim added the p1 Painful if we don't fix, won't block releasing label Dec 24, 2018
@coveralls
Copy link

coveralls commented Dec 24, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 764

  • 8 of 16 (50.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 47.949%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/reducers/activities.js 1 2 50.0%
packages/core/src/sagas/sendTypingOnSetSendBoxSaga.js 0 7 0.0%
Totals Coverage Status
Change from base Build 763: 0.06%
Covered Lines: 784
Relevant Lines: 1475
💛 - Coveralls

cwhitten
cwhitten reviewed Dec 26, 2018
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
corinagum
corinagum suggested changes Dec 31, 2018
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending naming discussion

README.md Outdated Show resolved Hide resolved
samples/07.b.customization-send-typing/index.html Outdated Show resolved Hide resolved
@compulim
Copy link
Contributor Author

@cwhitten @corinagum I have updated from "send typing" to "send typing indicator".

I only renamed the sample for now. Will submit another PR for renaming actions, reducers, sagas, selectors, props, and add deprecation notes.

@compulim compulim mentioned this pull request Jan 13, 2019
Merged
@corinagum
Copy link
Contributor

I approved, but just in case wait for confirmation from @cwhitten :)

@compulim compulim merged commit b341439 into microsoft:master Jan 16, 2019
@compulim compulim deleted the fix-send-typing branch January 16, 2019 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@cwhitten cwhitten cwhitten approved these changes

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

Assignees
No one assigned
Labels
bug Indicates an unexpected problem or an unintended behavior. p1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@compulim @coveralls @corinagum @cwhitten