Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix microphone button not re-enabled after error #2241

Merged
merged 5 commits into from
Jul 31, 2019
Merged

Fix microphone button not re-enabled after error #2241

merged 5 commits into from
Jul 31, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jul 30, 2019 •
edited
Loading

Fixes #2240.

Changelog Entry

Description

Microphone button is permanently disabled after receiving and error from speech engine. The error could be:

  • Muted microphone
  • No recognizable speech
  • Network error

Instead, the microphone button should not be permanently disabled.

Specific Changes

  • Set dictateState to IDLE even if currently is STOPPING

@coveralls
Copy link

coveralls commented Jul 30, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 64.984% when pulling 7c26df0 on compulim:fix-2240 into 5dc8e43 on microsoft:master.

corinagum
corinagum approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corinagum corinagum merged commit 76c0f20 into microsoft:master Jul 31, 2019
@compulim compulim mentioned this pull request Oct 4, 2019
Closed
13 tasks
@compulim compulim mentioned this pull request Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Speech: Stop microphone button should re-enable the button after a few seconds
3 participants
@compulim @coveralls @corinagum