Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating submitSendBoxSaga.js to send sendBoxValue.trim() #2331

Merged
merged 10 commits into from
Aug 21, 2019
Merged

Updating submitSendBoxSaga.js to send sendBoxValue.trim() #2331

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
26a083b
Updating submitSendBoxSaga.js
jimmyjames177414 Aug 16, 2019
7fc164f
Updating CHANGELOG.md
jimmyjames177414 Aug 19, 2019
2c12280
Updating CHANGELOG.md
jimmyjames177414 Aug 19, 2019
9bfeb46
Removing redundancy in SendButton.js
jimmyjames177414 Aug 19, 2019
81a92ea
Removing redundancy in TextBox.js
jimmyjames177414 Aug 19, 2019
fc12956
Merge branch 'master' into patch-2
corinagum Aug 19, 2019
deed7b9
Merge branch 'master' into patch-2
corinagum Aug 19, 2019
0474d1c
Refactoring SendButton.js
jimmyjames177414 Aug 19, 2019
6a0800c
Merge branch 'master' into patch-2
jimmyjames177414 Aug 20, 2019
511f30c
Correcting Lint errors in SendButton.js
jimmyjames177414 Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### Fixed

- Fix [#2328](https://github.com/microsoft/BotFramework-WebChat/issues/2328). Updating submitSendBoxSaga.js to send sendBoxValue.trim(), by [@jimmyjames177414](https://github.com/jimmyjames177414) in PR [#2331](https://github.com/microsoft/BotFramework-WebChat/pull/2331)
- Fix [#2160](https://github.com/microsoft/BotFramework-WebChat/issues/2160). Clear suggested actions after clicking on a suggested actions of type `openUrl`, by [@tdurnford](https://github.com/tdurnford) in PR [#2190](https://github.com/microsoft/BotFramework-WebChat/pull/2190)
- Fix [#1954](https://github.com/microsoft/BotFramework-WebChat/issues/1954). Estimate clock skew and adjust timestamp for outgoing activity, by [@compulim](https://github.com/compulim) in PR [#2208](https://github.com/microsoft/BotFramework-WebChat/pull/2208)
- Fix [#2240](https://github.com/microsoft/BotFramework-WebChat/issues/2240). Fix microphone button should be re-enabled after error, by [@compulim](https://github.com/compulim) in PR [#2241](https://github.com/microsoft/BotFramework-WebChat/pull/2241)
Expand Down Expand Up @@ -96,6 +97,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- [Single sign-on for Microsoft Teams apps](https://microsoft.github.io/BotFramework-WebChat/19.c.single-sign-on-for-teams-apps/), by [@compulim](https://github.com/compulim) in [#2196](https://github.com/microsoft/BotFramework-WebChat/pull/2196)
- [Customize Web Chat with Reaction Buttons](https://microsoft.github.io/BotFramework-WebChat/09.customization-reaction-buttons/). Updated reaction handlers to send `messageReaction` activities, by [@tdurnford](https://github.com/tdurnford) in [#2239](https://github.com/microsoft/BotFramework-WebChat/pull/2239)

## [4.5.3] - 2019-16-07
tdurnford marked this conversation as resolved.
Show resolved Hide resolved

- Fix [#2328](https://github.com/microsoft/BotFramework-WebChat/issues/2328). Updating submitSendBoxSaga.js to send sendBoxValue.trim(), by [@jimmyjames177414](https://github.com/jimmyjames177414) in PR [#2331](https://github.com/microsoft/BotFramework-WebChat/pull/2331)

## [4.5.2] - 2019-08-07

- Fix [#2273](https://github.com/microsoft/BotFramework-WebChat/issues/2273). Add `ScreenReaderText` component, by [@corinagum](https://github.com/corinagum) in PR [#2278](https://github.com/microsoft/BotFramework-WebChat/pull/2278)
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/sagas/submitSendBoxSaga.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function* submitSendBox() {
const sendBoxValue = yield select(sendBoxValueSelector);

if (sendBoxValue) {
yield put(sendMessage(sendBoxValue, method));
yield put(sendMessage(sendBoxValue.trim(), method));
yield put(setSendBox(''));
}
});
Expand Down