Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated tests to Offline Mockbot #2392

Merged
merged 5 commits into from
Sep 12, 2019
Merged

Conversation

tdurnford
Copy link
Contributor

Fixes #1680

Changelog Entry

Description

Migrated Web Chat tests from MockBot to Offline MockBot

Specific Changes

Updated Web Chat tests to run with Offline Mock Bot by default. Developers can choose to have a test run with Online Mock Bot by setting the offline option to false when they setup the web driver.

const { driver } = await setupWebDriver({ offline: false });

  • Testing Added
    Tests would be redundant

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending one comment about offline.

__tests__/setup/web/index.html Show resolved Hide resolved
__tests__/setup/web/index.html Show resolved Hide resolved
__tests__/setup/web/index.html Outdated Show resolved Hide resolved
__tests__/setup/web/index.html Outdated Show resolved Hide resolved
__tests__/cardActionMiddleware.js Outdated Show resolved Hide resolved
@corinagum corinagum merged commit 9282174 into microsoft:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make MockBot offline for testing
3 participants