Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample for using different version of React in hosting app via NPM packages #2509

Merged
merged 9 commits into from
Oct 30, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Oct 29, 2019

Changelog Entry

Description

Starting from Web Chat 4.6, we are migrating to React Hooks and requiring React 16.8.6 or up.

In this sample, we will show how to use Web Chat in an hosting app with React version 16.0.0, instead of the required 16.8.6.

Specific Changes

  • Added a new sample 23.a.hybrid-react-npm

  • Testing Added
    • Currently, no tests will be added for samples

Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

README.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
samples/23.a.hybrid-react-npm/README.md Outdated Show resolved Hide resolved
samples/23.a.hybrid-react-npm/README.md Outdated Show resolved Hide resolved
samples/23.a.hybrid-react-npm/README.md Outdated Show resolved Hide resolved
samples/23.a.hybrid-react-npm/README.md Outdated Show resolved Hide resolved
samples/23.a.hybrid-react-npm/README.md Outdated Show resolved Hide resolved
samples/23.a.hybrid-react-npm/README.md Outdated Show resolved Hide resolved
samples/23.a.hybrid-react-npm/README.md Outdated Show resolved Hide resolved
samples/23.a.hybrid-react-npm/README.md Outdated Show resolved Hide resolved
compulim and others added 4 commits October 29, 2019 17:24
Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim compulim merged commit 7261d33 into microsoft:master Oct 30, 2019
@compulim compulim deleted the sample-hybrid-react branch October 30, 2019 03:28
@compulim compulim mentioned this pull request Oct 31, 2019
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants