Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add React Hooks for customization (part 13) #2554

Merged
merged 17 commits into from
Dec 3, 2019
Merged

Add React Hooks for customization (part 13) #2554

merged 17 commits into from
Dec 3, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Nov 4, 2019 •
edited
Loading

Related to #2539.

Changelog Entry

  • Resolves #2539, added React hooks for customization, by @compulim, in the following PRs:
    • PR #2554: useRenderActivity, useRenderAttachment

Description

Add several post message related hooks:

  • useRenderActivity
  • useRenderAttachment

Specific Changes

  • Added the following hooks:
    • useRenderActivity
    • useRenderAttachment
  • Updated components to use aforementioned hooks
  • Testing Added

@compulim compulim force-pushed the feat-redux-hooks-13 branch 9 times, most recently from 1f50a59 to b8d1dfa Compare November 4, 2019 10:52
@coveralls
Copy link

coveralls commented Nov 4, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 63.693% when pulling 20d46b7 on compulim:feat-redux-hooks-13 into 95ab4e6 on microsoft:master.

corinagum
corinagum reviewed Nov 26, 2019
View reviewed changes
HOOKS.md Outdated Show resolved Hide resolved
__tests__/hooks/useStartDictate.js Show resolved Hide resolved
packages/component/src/BasicTranscript.js Outdated Show resolved Hide resolved
packages/component/src/BasicTranscript.js Outdated Show resolved Hide resolved
@compulim compulim merged commit e4c7e20 into microsoft:master Dec 3, 2019
@compulim compulim deleted the feat-redux-hooks-13 branch December 3, 2019 03:00
@corinagum corinagum added the R7 label Dec 3, 2019
@compulim compulim mentioned this pull request Dec 10, 2019
Closed
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford left review comments

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to Redux Hooks
4 participants
@compulim @coveralls @corinagum @tdurnford