Re-execute auth policies on conflict #4102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
auth_transactionality@48498 aka 20220811.6 vs main ewma over 20 builds from 48239 to 48486 Click to see tablemain
auth_transactionality
|
eddyashton
added
2.x-todo
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
eddyashton
added a commit
to eddyashton/CCF
that referenced
this pull request
Aug 11, 2022
(cherry picked from commit 33b9f4c)
eddyashton
added
the
backported
MahatiC
pushed a commit
to MahatiC/CCF
that referenced
this pull request
Aug 15, 2022
(cherry picked from commit 33b9f4c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #4101, so keeping as a draft until that has merged. This will also need to be manually merged with #4093, since they touch the same lines of auth code.
The auth policies were previously executed once, at the start of
process_command(), and were not re-executed on Tx conflicts, meaning they could break serializability. The fix is simple (moving a block of code infrontend.h), but it's non-trivial to test. I added aTestManualConflictsFrontendthat usescondition_variablewait points to insert arbitrary execution (including committing other transactions) during an endpoint's execution. I've also added a bunch of other unit tests with this, to confirm operations have the expected dependencies. The relevant unit test, testing the auth policy issue that we're actually looking at, is the last one ("Removed caller ident post-read").