Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daily build: Empty URIs should return a 404 #4215

Merged
merged 5 commits into from
Sep 12, 2022

Conversation

eddyashton
Copy link
Member

Fixing a bug introduced by #4205.

Also adding test cases to catch this regression faster in future, in both unit and e2e tests.

@eddyashton eddyashton requested a review from a team September 12, 2022 09:09
@ghost
Copy link

ghost commented Sep 12, 2022

empty_uri_is_404@49585 aka 20220912.9 vs main ewma over 20 builds from 49239 to 49569

Click to see table

main

build_id build_number tpcc_virtual_cft^ tpcc_virtual_cft_mem ls_virtual_cft^ ls_virtual_cft_mem ls_jwt_virtual_cft^ ls_jwt_virtual_cft_mem ls_js_virtual_cft^ ls_js_virtual_cft_mem ls_v8_virtual_cft^ ls_v8_virtual_cft_mem ls_full_js_virtual_cft^ ls_full_js_virtual_cft_mem ls_full_v8_virtual_cft^ ls_full_v8_virtual_cft_mem ls_js_jwt_virtual_cft^ ls_js_jwt_virtual_cft_mem hist_sgx_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
49239 20220905.9 nan nan nan nan nan nan nan nan nan nan nan nan nan nan nan nan 20484.8 6399.81 8.69049e+07 19883.2 1.58639e+07 5603.01 1.53396e+07 2547.35 9.83456e+06 1591.61 1.66597e+08 2158.88 9.57242e+06 1408.33 9.81771e+07 1918.08 9.04813e+06 899541 1.36569e+06 9.35151e+06 3.58042e+07
49242 20220905.10 11506.8 0 42664 0 10683.9 0 4594.58 0 2855.57 0 3581.18 0 2497.85 0 3355.62 0 23463.6 6147.41 8.24484e+07 19864.5 1.63882e+07 5578.21 1.53396e+07 2483.16 9.83456e+06 1576.76 1.66859e+08 2073.83 9.04813e+06 1392.2 9.79149e+07 1928.57 8.78598e+06 903708 1.37145e+06 9.35151e+06 3.59298e+07
49243 20220905.11 11320.7 0 40621.7 0 10260.7 0 4676.21 0 2798.88 0 3589.82 0 2489.91 0 3371.18 0 22359.5 6244.91 8.3497e+07 19894.9 1.63882e+07 5530.05 1.56017e+07 2549.59 1.00967e+07 1588.65 1.66597e+08 2116.87 9.31027e+06 1395.13 9.81771e+07 1834.76 1.08831e+07 900054 1.36934e+06 9.26269e+06 3.59298e+07
49259 20220906.1 11256.8 0 41564.7 0 10234.3 0 4520.47 0 2874.51 0 3543.63 0 2443.25 0 3402.88 0 26178.7 6298.81 8.32349e+07 19838.2 1.58639e+07 5637.77 1.53396e+07 2488.7 9.83456e+06 1568.27 1.66597e+08 2138.73 9.31027e+06 1396.55 9.79149e+07 1926.24 9.04813e+06 906229 1.36505e+06 9.19206e+06 3.58663e+07
49287 20220906.8 11181.6 0 42071 0 10734 0 4579.41 0 2790.3 0 3547.34 0 2452.34 0 3300.3 0 23064.7 6313.21 8.27106e+07 19488.2 1.6126e+07 5528.88 1.53396e+07 2479.37 9.83456e+06 1554.43 1.66597e+08 2101.41 9.31027e+06 1374.59 9.81771e+07 1926.35 9.04813e+06 875774 1.35881e+06 9.17559e+06 3.44781e+07
49321 20220907.2 11546.3 0 40423.4 0 10417.5 0 4606.41 0 2792.86 0 3582.52 0 2483.64 0 3527.99 0 27714.5 6335.3 8.37592e+07 19895.8 1.66503e+07 5568.19 1.53396e+07 2510.33 1.2456e+07 1534.08 1.66597e+08 2077.44 9.04813e+06 1375.62 9.79149e+07 1928.95 9.04813e+06 883971 1.39737e+06 9.40736e+06 3.63766e+07
49338 20220907.8 nan nan nan nan nan nan nan nan nan nan nan nan nan nan nan nan 20492.2 6293.79 8.27106e+07 19885 1.6126e+07 5571.13 1.53396e+07 2498.72 9.83456e+06 1600.78 1.66597e+08 2120.24 9.31027e+06 1397.94 9.79149e+07 1927.35 9.04813e+06 905949 1.37615e+06 9.25855e+06 3.55556e+07
49351 20220907.13 11695.3 0 43199.7 0 10312 0 4599.55 0 2757.17 0 3700.07 0 2491.49 0 3372.11 0 24225.7 6106.44 8.37592e+07 19329.5 1.69124e+07 5552.91 1.53396e+07 2496.15 1.03588e+07 1597.67 1.66335e+08 2075.94 9.31027e+06 1389.28 9.76528e+07 1926.07 1.11453e+07 908722 1.35772e+06 9.19615e+06 3.63759e+07
49358 20220907.15 11558.2 0 42148.8 0 10353.5 0 4800.17 0 2874.26 0 3561.8 0 2494.51 0 3718.59 0 23107.4 6491.99 8.37592e+07 19825 1.6126e+07 5599.85 1.53396e+07 2556.85 9.83456e+06 1620.53 1.645e+08 2084.3 9.31027e+06 1424.05 9.81771e+07 1940.17 9.04813e+06 924848 1.3793e+06 9.32172e+06 3.58042e+07
49399 20220907.32 11359.8 0 42625.6 0 10315.6 0 4768.15 0 2786.84 0 3618.43 0 2492.28 0 3406.83 0 27670.4 6238.04 8.29727e+07 19676.6 1.6126e+07 5580.52 1.56017e+07 2495.42 1.00967e+07 1596.16 1.66597e+08 2073.91 1.21939e+07 1394.62 9.63421e+07 1884.05 9.31027e+06 886539 1.37579e+06 9.02994e+06 3.46531e+07
49412 20220908.2 11376.9 0 42804.1 0 10490.8 0 4717.12 0 2818.32 0 3554.57 0 2444.03 0 3720.75 0 26838.4 6211.39 8.32349e+07 19699.9 1.66503e+07 5673.08 1.58639e+07 2558.06 1.03588e+07 1589.88 1.66859e+08 2157.25 9.31027e+06 1392.74 9.79149e+07 1933.43 9.04813e+06 903711 1.37182e+06 9.22103e+06 3.58042e+07
49440 20220908.13 11180.9 0 42591.4 0 10667.7 0 4595.63 0 2777.81 0 3648.87 0 2481.74 0 3544.75 0 28059.2 6383.7 8.27106e+07 19646.1 1.66503e+07 5591.16 1.6126e+07 2489.13 9.83456e+06 1594.8 1.66859e+08 2118.61 9.57242e+06 1404.82 9.79149e+07 1942.16 9.31027e+06 893186 1.36287e+06 9.21269e+06 3.5128e+07
49473 20220908.24 11868.2 0 41080.7 0 10816.1 0 4775.45 0 2847.94 0 3588.01 0 2543.06 0 3403.33 0 24019.1 6339.17 8.3497e+07 19518.1 1.6126e+07 5549.33 1.56017e+07 2541.39 1.00967e+07 1602.39 1.66859e+08 2086.69 9.31027e+06 1405.05 9.81771e+07 1931.35 9.31027e+06 901963 1.36588e+06 9.23771e+06 3.58669e+07
49482 20220909.3 10790.1 0 42776.5 0 10113.9 0 4699.44 0 2771.52 0 3543.48 0 2437.7 0 3553.49 0 22366.3 6319.97 8.32349e+07 19735.6 1.69124e+07 5648.72 1.56017e+07 2610.42 1.00967e+07 1591.62 1.66859e+08 2112.5 9.57242e+06 1402.07 9.81771e+07 1928.91 9.04813e+06 900269 1.37209e+06 9.24496e+06 3.51244e+07
49490 20220909.6 10788 0 40098 0 10113.8 0 4705.29 0 2793.92 0 3722.38 0 2391.35 0 3386.15 0 23675.5 6357.3 8.32349e+07 19762.2 1.71746e+07 5626.32 1.58639e+07 2603.41 1.00967e+07 1589.39 1.65024e+08 2078 9.57242e+06 1403.63 9.84392e+07 1930.3 9.31027e+06 887074 1.37523e+06 9.21273e+06 3.55556e+07
49512 20220909.14 10808.7 0 43195.6 0 10427.1 0 4781.33 0 2725.07 0 3771.74 0 2440.82 0 3637.08 0 31282.1 6345.64 8.37592e+07 19628.7 1.66503e+07 5590.22 1.56017e+07 2500.39 9.83456e+06 1606.46 1.67121e+08 2115.8 9.57242e+06 1392.44 9.81771e+07 1934.31 1.08831e+07 897053 1.37799e+06 9.22514e+06 3.58663e+07
49527 20220909.20 11283.9 0 40754.8 0 10726.7 0 4698.84 0 2761.97 0 3686.62 0 2497.39 0 3696.51 0 29582.5 6344.24 8.21863e+07 19683.7 1.66503e+07 5544.58 1.56017e+07 2556.36 9.83456e+06 1580.21 1.64762e+08 2117.13 9.57242e+06 1381.84 9.79149e+07 1929.75 9.31027e+06 900451 1.3561e+06 9.49018e+06 3.58669e+07
49550 20220909.26 11156.1 0 41319.1 0 10021.3 0 4700.23 0 2818.99 0 3686.21 0 2488.34 0 3385.55 0 21625.8 6318.42 8.40213e+07 19713.8 1.6126e+07 5607.74 1.58639e+07 2563.5 1.03588e+07 1580.96 1.67121e+08 2086.42 9.57242e+06 1407.08 9.76528e+07 1927.31 9.31027e+06 900851 1.37422e+06 9.22107e+06 3.58669e+07
49564 20220912.2 11614.1 0 41461.4 0 10442.9 0 4767.08 0 2829.87 0 3676.69 0 2487.63 0 3502.76 0 24945 6189.17 8.32349e+07 19626.8 1.66503e+07 5597.1 1.53396e+07 2536.6 1.03588e+07 1587.5 1.66859e+08 2150.63 1.21939e+07 1392.93 9.79149e+07 1896.21 9.31027e+06 894738 1.37098e+06 9.22926e+06 3.59292e+07
49569 20220912.4 11354.2 0 42977.9 0 10169.1 0 4780.73 0 2805.3 0 3740.43 0 2500.98 0 3381.8 0 23732.5 6431.28 8.32349e+07 19872.6 1.6126e+07 5667.34 1.56017e+07 2488.03 1.00967e+07 1612.69 1.66859e+08 2152.87 9.57242e+06 1409.99 9.84392e+07 1934.5 9.31027e+06 888574 1.37347e+06 9.21269e+06 3.57411e+07

empty_uri_is_404

build_id build_number tpcc_virtual_cft^ tpcc_virtual_cft_mem tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_virtual_cft^ ls_virtual_cft_mem ls_jwt_virtual_cft^ ls_jwt_virtual_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_js_virtual_cft^ ls_js_virtual_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_v8_virtual_cft^ ls_v8_virtual_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_virtual_cft^ ls_full_js_virtual_cft_mem ls_full_v8_virtual_cft^ ls_full_v8_virtual_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_js_jwt_virtual_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem hist_sgx_cft^ ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
49575 20220912.6 11265.4 0 6436.53 8.32349e+07 41175.1 0 10715.3 0 19628.9 1.63882e+07 4656.93 0 5655.01 1.56017e+07 2830.44 0 2555.85 1.03588e+07 3687.76 0 2498.85 0 1606.51 1.67121e+08 3352.23 0 2157.29 9.57242e+06 28858.4 1426.8 9.81771e+07 1930.81 9.31027e+06 889114 1.3636e+06 9.21269e+06 3.56788e+07
49582 20220912.8 11216.9 0 6291.58 8.37592e+07 38954.9 0 10469.4 0 19636.7 1.63882e+07 4650.6 0 5633.25 1.56017e+07 2866.53 0 2556.49 1.00967e+07 3707.38 0 2515.84 0 1597.89 1.65024e+08 3568.21 0 2118 9.57242e+06 26013.2 1404.65 9.84392e+07 1936.33 9.04813e+06 899890 1.37153e+06 9.26265e+06 3.58663e+07
49585 20220912.9 11410.7 0 6293.33 8.29727e+07 41982.5 0 10092.5 0 19843.7 1.63882e+07 4863.45 0 5545.81 1.56017e+07 2858.34 0 2500.42 1.00967e+07 3712.76 0 2482.6 0 1598.34 1.65024e+08 3405 0 2083.88 9.57242e+06 24670.1 1356.2 9.79149e+07 1972.67 9.57242e+06 895098 1.36314e+06 9.19202e+06 3.5128e+07

images

@eddyashton eddyashton merged commit 63f5f1d into microsoft:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants