-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically return gRPC errors for framework-level errors #4813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahatiC
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
grpc_status_error@60112 aka 20230110.18 vs main ewma over 20 builds from 59447 to 60058 Click to see tablemain
grpc_status_error
|
eddyashton
reviewed
Jan 10, 2023
eddyashton
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4211
We now automatically return gRPC errors to gRPC clients that trigger a framework-level errors (e.g. authentication failure). To do so, we automatically convert the
http_status
togrpc_status
if the requestcontent-type
isappplication/grpc
.Note that to get this to work is a smaller change than I first anticipated as we not need to link in
libprotobuf
as the error is simply sent back to the client in HTTP/2 trailers. However, I'm planning to link inlibprotobuf
to a newlibccf_grpc.a
library that can be linked to apps that create gRPC endpoints (future PR).