-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for SNP/Virtual builds with no dependency on Open Enclave #5308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optional_sgx_quote@70969 aka 20230530.6 vs main ewma over 20 builds from 70682 to 70961 Click to see tablemain
optional_sgx_quote
|
eddyashton
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5291
This PR enables the upgrade of the Virtual/SNP images to Ubuntu 22.04 (so that we can pick up the OpenSSL 3.x Debian package). To do so, we allow for builds of SNP/Virtual without Open Enclave Host Verify (with a new
REQUIRE_OPENENCLAVE
CMake flag,ON
by default), which is currently only available for Ubuntu 20.04. The implications for these builds is that they can no longer verify SGX quotes, preventing code upgrades from SGX to SNP (only for such builds) and JWT verification issued with SGX claims.