Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for SNP/Virtual builds with no dependency on Open Enclave #5308

Merged
merged 19 commits into from
May 30, 2023

Conversation

jumaffre
Copy link
Contributor

@jumaffre jumaffre commented May 25, 2023

Part of #5291

This PR enables the upgrade of the Virtual/SNP images to Ubuntu 22.04 (so that we can pick up the OpenSSL 3.x Debian package). To do so, we allow for builds of SNP/Virtual without Open Enclave Host Verify (with a new REQUIRE_OPENENCLAVE CMake flag, ON by default), which is currently only available for Ubuntu 20.04. The implications for these builds is that they can no longer verify SGX quotes, preventing code upgrades from SGX to SNP (only for such builds) and JWT verification issued with SGX claims.

@jumaffre jumaffre requested a review from a team May 25, 2023 16:38
@ghost
Copy link

ghost commented May 26, 2023

optional_sgx_quote@70969 aka 20230530.6 vs main ewma over 20 builds from 70682 to 70961

Click to see table

main

build_id build_number Commit latency factor ls_virtual_cft^ pi_ls_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem ls_js_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_full_js_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ pi_basic_virtual_cft^ pi_basic_sgx_cft^ pi_basic_sgx_cft_mem
70682 20230522.5 0.800285 43803.2 46287.5 11405.2 12701.9 20305.5 1.88908e+07 4247.21 20509.8 1.25993e+07 3327.07 6769.17 1.67936e+07 6557.5 6.30784e+06 3125.33 1710.79 1.05021e+07 49394.4 1423.41 1.05021e+07 1408.78 1.05021e+07 829768 1.17658e+06 8.14667e+06 3.12405e+07 nan nan nan
70707 20230522.15 0.794519 47954.8 49325.3 12479.8 13010.8 20328.1 1.88908e+07 4450.34 20476.1 1.25993e+07 3482.17 6676.08 1.88908e+07 6502.6 6.30784e+06 3264.51 1712.94 1.05021e+07 46050.4 1420.42 1.05021e+07 1411.15 1.05021e+07 828546 1.18055e+06 8.1295e+06 3.07697e+07 nan nan nan
70718 20230522.18 0.800798 45817.4 47497.4 12569.7 12987.4 20250.8 1.88908e+07 4457.46 20472.4 1.25993e+07 3582.61 6721.66 1.88908e+07 6561.6 6.30784e+06 3367.13 1714.52 1.05021e+07 48088.5 1418.17 1.05021e+07 1408.29 1.05021e+07 834967 1.1861e+06 8.13247e+06 3.07951e+07 nan nan nan
70727 20230523.1 0.796101 45451.1 47770.4 12509.7 13078.9 20381.1 1.88908e+07 4373.86 20613.8 1.25993e+07 3578.48 6728.23 1.67936e+07 6555.7 6.30784e+06 3262.66 1731.53 1.05021e+07 51249.9 1422.4 1.05021e+07 1418.29 1.05021e+07 804453 1.16904e+06 8.15264e+06 3.09062e+07 nan nan nan
70757 20230523.13 0.790054 45600.3 47585.5 12440 12821.4 20296.9 1.88908e+07 4426.49 20508.9 1.25993e+07 3490.68 6313.27 1.67936e+07 6518.2 6.30784e+06 3304.11 1709.75 1.05021e+07 47366.3 1414.92 1.05021e+07 1401.35 1.05021e+07 836308 1.18537e+06 8.04238e+06 3.07924e+07 nan nan nan
70776 20230524.1 0.787379 45676.5 47518.2 12636.4 13216.9 20220 1.88908e+07 4397.92 20457.6 1.25993e+07 3570.86 6715.71 1.67936e+07 6516.7 6.30784e+06 3228.72 1712.9 1.05021e+07 48739.3 1421.07 1.05021e+07 1404.25 1.05021e+07 828970 1.18033e+06 8.1346e+06 2.96519e+07 nan nan nan
70782 20230524.5 0.806205 45556.5 47379.9 12500.7 12968.3 20183.2 1.88908e+07 4482.81 20433.3 1.25993e+07 3483.32 6748.26 1.67936e+07 6554.6 6.30784e+06 3283.98 1718.71 1.05021e+07 48546 1418.22 1.05021e+07 1407.88 1.05021e+07 838299 1.18346e+06 8.15332e+06 3.07979e+07 nan nan nan
70796 20230524.9 0.777891 45627.8 47815.8 12536.3 13170.4 20389.3 1.88908e+07 4425.14 20462.8 1.25993e+07 3577.89 6718.32 1.67936e+07 6557 6.30784e+06 3296.92 1713.6 1.05021e+07 46972.3 1420.78 1.05021e+07 1416.19 1.05021e+07 834627 1.18335e+06 8.15365e+06 3.0772e+07 nan nan nan
70809 20230524.13 0.802159 47935 49074.7 12536.3 12903.7 20439.4 1.88908e+07 4463.22 20452 1.25993e+07 3494.83 6683.22 1.88908e+07 6465.7 6.30784e+06 3280.94 1713.57 1.05021e+07 48841.7 1420.32 1.05021e+07 1421.29 1.05021e+07 837427 1.17653e+06 8.16887e+06 3.08569e+07 nan nan nan
70825 20230524.19 0.768386 47987.9 49473.3 12480.4 13060.6 20338.2 1.88908e+07 4432.77 20430.2 1.25993e+07 3491.78 6712.83 1.67936e+07 6519 6.30784e+06 3267.73 1714.66 1.05021e+07 48889.2 1421.19 1.05021e+07 1396.12 1.05021e+07 825814 1.17603e+06 8.15196e+06 3.0803e+07 nan nan nan
70834 20230524.22 0.788926 47706.6 50041 12594.9 13147.5 20328.8 1.88908e+07 4418.11 20384.7 1.25993e+07 3550.29 6716.49 1.67936e+07 6490.9 6.30784e+06 3358.66 1620.92 1.05021e+07 47232.8 1416.52 1.05021e+07 1403.23 1.05021e+07 827281 1.17768e+06 8.15403e+06 3.14434e+07 nan nan nan
70848 20230525.2 0.764852 48033.7 49344.7 12442.9 12839.6 20294.7 1.88908e+07 4439.06 20480.4 1.25993e+07 3482.16 6728.18 1.67936e+07 6564 6.30784e+06 3243.03 1714.23 1.05021e+07 48383.2 1419.05 1.05021e+07 1421.4 1.05021e+07 801066 1.16398e+06 8.15063e+06 3.08294e+07 nan nan nan
70853 20230525.5 0.768084 45958.3 48064 12579 13206.7 20310.8 1.88908e+07 4457.49 20514.5 1.25993e+07 3497.55 6671.58 1.67936e+07 6557 6.30784e+06 3266.43 1712.95 1.05021e+07 43846.6 1428.95 1.05021e+07 1422.09 1.05021e+07 832192 1.17515e+06 8.17451e+06 3.0772e+07 nan nan nan
70865 20230525.9 0.786008 45675 48739.4 12579 13109.1 20214.6 1.88908e+07 4453.97 20464.8 1.25993e+07 3476.35 6358.05 1.67936e+07 6502.5 6.30784e+06 3219.82 1710.88 1.05021e+07 46328.9 1418.61 1.05021e+07 1406.75 1.05021e+07 833914 1.1784e+06 8.17027e+06 3.08415e+07 nan nan nan
70877 20230525.13 0.794755 45934.3 48428.5 12570.5 13170.2 20359 1.88908e+07 4461.48 20465.8 1.25993e+07 3475.11 6676.38 1.67936e+07 6549.6 6.30784e+06 3255.95 1712.51 1.05021e+07 50575.2 1417.26 1.05021e+07 1409.9 1.05021e+07 838216 1.17488e+06 8.16681e+06 3.0809e+07 nan nan nan
70890 20230525.18 0.824966 45752 45085.9 12519.6 12887.1 20256.8 1.88908e+07 4466.87 20475.5 1.25993e+07 3494.19 6687.4 1.67936e+07 6511.7 6.30784e+06 3294.38 1713.61 1.05021e+07 48388.8 1412.75 1.05021e+07 1405.36 1.05021e+07 833584 1.17758e+06 8.15433e+06 3.07489e+07 nan nan nan
70913 20230526.1 0.775 45465.9 48431.1 12670.9 12951.5 20281.4 1.88908e+07 4459.58 20525.5 1.25993e+07 3557.35 6712.33 1.67936e+07 6555.2 6.30784e+06 3239.73 1711.13 1.05021e+07 46459.8 1430.04 1.05021e+07 1402.67 1.05021e+07 818517 1.17913e+06 8.15436e+06 2.98056e+07 nan nan nan
70936 20230526.10 0.821101 45729.2 48747.5 12462.9 13129.4 20373.4 1.88908e+07 4432.86 20532.5 1.25993e+07 3450.04 6720.57 1.67936e+07 6519.8 6.30784e+06 3229.12 1731.27 1.05021e+07 48927.4 1418.71 1.05021e+07 1419.35 1.05021e+07 823856 1.18116e+06 8.15235e+06 2.99661e+07 56514.4 23089.8 1.25993e+07
70948 20230529.3 0.811405 46102.1 48458.8 12669.6 12849.8 20392.1 1.88908e+07 4416.14 20488.2 1.25993e+07 3577.84 6698.89 1.67936e+07 6554.7 6.30784e+06 3225.76 1714.14 1.05021e+07 50943.7 1422.96 1.05021e+07 1422.19 1.05021e+07 822933 1.18082e+06 8.17415e+06 3.06518e+07 56351.3 23001.5 1.25993e+07
70961 20230530.3 0.813727 45788.8 48571 12528.1 12996.4 20242.1 1.88908e+07 4419.43 20481.9 1.25993e+07 3566.12 6679.21 1.67936e+07 6510.7 6.30784e+06 3252.82 1715.43 1.05021e+07 50885.1 1420.64 1.05021e+07 1422.18 1.05021e+07 838192 1.18066e+06 8.15543e+06 3.08722e+07 55477.3 23050 1.25993e+07

optional_sgx_quote

build_id build_number Commit latency factor ls_virtual_cft^ pi_ls_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ hist_sgx_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ pi_basic_virtual_cft^ pi_basic_sgx_cft^ pi_basic_sgx_cft_mem
70934 20230526.9 0.805965 45811.7 48908.1 12457 12981.4 4420.35 3567.01 3259.37 44369.1 20233.8 1.88908e+07 20552.8 1.05021e+07 6686.39 1.67936e+07 6555.7 6.30784e+06 1732.26 1.05021e+07 1435.07 1.05021e+07 1424.18 1.05021e+07 842803 1.18438e+06 8.15313e+06 3.07581e+07 nan nan nan
70966 20230530.5 0.820564 45691.7 48514.5 12496.6 13096.9 4448.79 3571.3 3292.39 46523.8 20421.6 1.88908e+07 20487.5 1.25993e+07 6723.21 1.67936e+07 6558.8 6.30784e+06 1733.29 1.05021e+07 1430.77 1.05021e+07 1404.01 1.05021e+07 834854 1.17343e+06 8.17242e+06 3.08174e+07 56033.1 23074.4 1.25993e+07
70969 20230530.6 0.789297 45535.1 48281.9 12423.1 12893.6 4428.85 3510.86 3286.68 46568.8 20210.7 1.88908e+07 20508 1.25993e+07 6359.22 1.88908e+07 6549.3 6.30784e+06 1715.54 1.05021e+07 1419.48 1.05021e+07 1401.53 1.05021e+07 834510 1.179e+06 8.17036e+06 3.08848e+07 56238.5 22998 1.25993e+07

images

@jumaffre jumaffre merged commit 19512e3 into microsoft:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants