Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove our copy of attestation container now that it has moved repos #5533

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Remove our copy of attestation container now that it has moved repos #5533

merged 4 commits into from
Aug 11, 2023

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Aug 10, 2023 •
edited
Loading

Resolve #5411

@achamayou achamayou requested a review from a team August 10, 2023 17:23
@ghost
Copy link

ghost commented Aug 10, 2023

remove_in_repo_attestation_container@74360 aka 20230810.34 vs main ewma over 18 builds from 73900 to 74354

Click to see table

main

build_id build_number Commit latency factor ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_js_virtual_cft^ pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_full_js_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem pi_basic_mt_virtual_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
73900 20230803.26 0.761475 45747.9 47879 54591.3 19968.8 1.88908e+07 20210.4 1.25993e+07 4452.6 22370.7 1.67936e+07 12539.3 13050.1 4460.49 1717.9 1.25993e+07 3549.61 6375.42 1.67936e+07 6574.4 6.30784e+06 3369.08 1740.58 1.05021e+07 34835.1 2.93765e+07 50311.8 1436.48 1.05021e+07 62961.5 1427.37 1.05021e+07 802461 1.17535e+06 8.15193e+06 3.2663e+07
73938 20230804.13 0.794691 45536.3 47977.5 53871.1 19979.8 1.88908e+07 20095.9 1.25993e+07 4520.8 22273 1.67936e+07 12812.8 12907.7 4482.1 1728.8 1.25993e+07 3568.79 6368.55 1.67936e+07 6664.7 6.30784e+06 3288.24 1744.42 1.05021e+07 34533.2 2.93765e+07 48176.6 1434.54 1.05021e+07 64405.2 1430.22 1.05021e+07 837139 1.17642e+06 8.14956e+06 3.09338e+07
73955 20230807.6 0.801307 43934.3 48026.8 54527.6 20091 1.88908e+07 20209 1.25993e+07 4516.7 22457 1.67936e+07 12421.1 13186.7 4423.14 1720.9 1.25993e+07 3572.61 6721.54 1.67936e+07 6526.9 6.30784e+06 3245.74 1742.64 1.05021e+07 34825.7 2.93765e+07 48325.6 1434.78 1.05021e+07 52415.6 1430.76 1.05021e+07 834230 1.17948e+06 8.15618e+06 3.1666e+07
74021 20230808.12 0.806516 43681.8 48001 54088.3 19886.6 1.88908e+07 20156.5 1.25993e+07 4509 22130.3 1.67936e+07 12857.1 13210.9 4461.7 1721.8 1.25993e+07 3405.82 6369.53 1.67936e+07 6461.2 6.30784e+06 3258.26 1740.76 1.05021e+07 34496.1 2.93765e+07 48007.7 1426.71 1.05021e+07 76483.6 1426.32 1.05021e+07 836568 1.17363e+06 8.17483e+06 3.079e+07
74045 20230808.18 0.798632 43896.8 48686.2 54294.8 20059.3 1.88908e+07 20193.6 1.25993e+07 4498.2 22276.2 1.67936e+07 12302.7 12966 4424.98 1718.8 1.25993e+07 3461.48 6707.62 1.67936e+07 6490.1 6.30784e+06 3361.39 1744.67 1.05021e+07 34498.6 2.93765e+07 44197.7 1419.59 1.05021e+07 71140.8 1423.88 1.05021e+07 837488 1.18204e+06 8.15472e+06 3.06642e+07
74091 20230808.32 0.816875 45839.1 48192.1 53263.5 19912.8 1.88908e+07 20200.7 1.05021e+07 4494.9 22149.1 1.67936e+07 12255.7 13172.8 4472.93 1712.5 1.25993e+07 3478.76 6685.9 1.67936e+07 6559 6.30784e+06 3266.03 1740.49 1.05021e+07 34255.1 3.14737e+07 46144.6 1436.63 1.05021e+07 57986 1420.62 1.05021e+07 832268 1.17896e+06 8.13069e+06 3.08397e+07
74119 20230808.42 0.766849 45793.7 48817.4 54224.7 19869.3 1.88908e+07 20186.5 1.25993e+07 4513.3 22133.5 1.67936e+07 12420.7 13063.7 4450.26 1722.9 1.25993e+07 3472.67 6369.95 1.67936e+07 6617.1 6.30784e+06 3278.97 1743.24 1.05021e+07 38839.3 2.51822e+07 45779.8 1437.34 1.05021e+07 71510.9 1430.97 1.05021e+07 828498 1.17809e+06 8.12853e+06 3.07845e+07
74126 20230809.2 0.782737 45877.7 48202.1 54061.9 19996.4 1.88908e+07 20238.4 1.25993e+07 4475.7 22240.6 1.67936e+07 12498.6 13000 4423.47 1730.9 1.25993e+07 3462.88 6738.61 1.67936e+07 6477.8 6.30784e+06 3244.08 1735.35 1.05021e+07 38818.5 2.72794e+07 48238.3 1421.47 1.05021e+07 63728.7 1428.06 1.05021e+07 828177 1.18125e+06 8.15076e+06 3.08341e+07
74144 20230809.10 0.814004 45581 48910.3 53169.6 20084.7 1.88908e+07 20145.3 1.25993e+07 4452 22264.7 1.67936e+07 12299.9 13086.1 4460.98 1730.1 1.05021e+07 3488.46 6749.53 1.67936e+07 6514.2 6.30784e+06 3274.21 1740.43 1.05021e+07 38912.8 2.72794e+07 48531.3 1434.92 1.05021e+07 72374.4 1430.77 1.05021e+07 837085 1.18276e+06 8.15358e+06 3.08955e+07
74156 20230809.14 0.748946 45785.3 48752.2 54049.5 20021.1 1.88908e+07 20180.7 1.25993e+07 4538.8 22321.9 1.67936e+07 12477 13398 4428.43 1726.9 1.25993e+07 3390.4 6745.43 1.67936e+07 6568.2 6.30784e+06 3238.46 1744.38 1.05021e+07 38930.8 2.51822e+07 48628.1 1438.96 1.05021e+07 59094.1 1430.84 1.05021e+07 836496 1.18226e+06 8.17408e+06 3.07222e+07
74168 20230809.18 0.779166 45606.3 48519 53277 19791.3 1.88908e+07 20106.6 1.25993e+07 4478.4 22031.8 1.67936e+07 12270.9 13336.9 4323.32 1719.6 1.25993e+07 3512.01 6345.17 1.67936e+07 6612.8 6.30784e+06 3270.95 1745.97 1.05021e+07 38749.1 2.72794e+07 46216.6 1430.83 1.05021e+07 78284.5 1428.89 1.05021e+07 833299 1.18088e+06 8.15345e+06 3.08592e+07
74187 20230809.25 0.774274 43709.3 47777.2 53243.4 19991.6 1.88908e+07 20205 1.25993e+07 4498.8 22241.6 1.67936e+07 12414.9 12980.8 4450.57 1731 1.25993e+07 3478.49 6355.36 1.67936e+07 6522.3 6.30784e+06 3374.03 1741.56 1.05021e+07 38041 2.51822e+07 47992.4 1438.17 1.05021e+07 81160.4 1428.85 1.05021e+07 843554 1.1739e+06 8.1552e+06 3.08132e+07
74198 20230809.27 0.786392 45753.8 47988.3 53468 20027.5 1.88908e+07 20218.1 1.25993e+07 4523.9 22184.1 1.67936e+07 12375.5 13240.8 4468.77 1731.2 1.25993e+07 3481.5 6713.28 1.67936e+07 6554.2 6.30784e+06 3276 1745.15 1.05021e+07 38024.5 2.72794e+07 48462.2 1440.4 1.05021e+07 71371.8 1433.28 1.05021e+07 820068 1.17261e+06 8.17294e+06 3.06729e+07
74209 20230810.2 0.8281 45612.7 47686.3 53371.5 20029.8 1.88908e+07 20147.2 1.25993e+07 4484.1 22127 1.67936e+07 12454.6 13357 4472.56 1732.5 1.25993e+07 3465.07 6694.4 1.67936e+07 6634.1 6.30784e+06 3186.1 1744.4 1.05021e+07 39033.7 2.51822e+07 45659.4 1439.43 1.05021e+07 68935.7 1430.93 1.05021e+07 826800 1.17717e+06 8.09717e+06 3.08662e+07
74219 20230810.7 0.792962 45726.1 47798.9 51803.2 20051 1.88908e+07 20143.2 1.25993e+07 4492.6 22240 1.67936e+07 12289.7 12886.8 4430.02 1734.9 1.25993e+07 3447.97 6415.64 1.67936e+07 6477.9 6.30784e+06 3364.46 1745.88 1.05021e+07 38833.2 2.72794e+07 46301.9 1437.82 1.05021e+07 81395.7 1431.42 1.05021e+07 835807 1.17952e+06 8.17196e+06 3.09426e+07
74245 20230810.11 0.777765 43727.5 47325.4 52670.2 20074.9 1.88908e+07 20112 1.25993e+07 4477.5 22037.1 1.67936e+07 12427.7 13126.6 4481.45 1725.4 1.25993e+07 3486.95 6698.89 1.67936e+07 6550.3 6.30784e+06 3311.64 1737.5 1.05021e+07 38844.9 2.72794e+07 44421.9 1434.15 1.05021e+07 77143.4 1422 1.05021e+07 836940 1.17657e+06 8.15322e+06 3.08183e+07
74291 20230810.18 0.821145 45729.3 48220.7 54045.9 19934.4 1.88908e+07 20116 1.25993e+07 4527.7 22221.4 1.67936e+07 12318.8 13038.3 4430.26 1729 1.25993e+07 3545.51 6368.12 1.67936e+07 6484.6 6.30784e+06 3380.55 1746.12 1.05021e+07 36102.1 2.72794e+07 50616.1 1439.84 1.05021e+07 74682.1 1426.05 1.05021e+07 836343 1.17805e+06 8.15264e+06 2.98904e+07
74354 20230810.33 0.812767 45640 47642.4 53935.3 19946.2 1.88908e+07 20162.1 1.25993e+07 4517.2 22112.1 1.67936e+07 12379.8 13370.8 4450.43 1725.6 1.25993e+07 3571.44 6689.93 1.67936e+07 6609.9 6.30784e+06 3345.81 1744.63 1.05021e+07 38639.9 2.72794e+07 46737.5 1435.11 1.05021e+07 61954.9 1428.85 1.05021e+07 830213 1.17571e+06 8.14674e+06 3.0835e+07

remove_in_repo_attestation_container

build_id build_number pi_basic_mt_virtual_cft^ Commit latency factor ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem hist_sgx_cft^ pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
74360 20230810.34 85111.9 0.819895 45972.1 49286.3 53730.5 4557.4 12289.3 13098.8 4464.93 3494.19 38626.5 2.72794e+07 3258.73 20044.9 1.88908e+07 20195.8 1.25993e+07 45780.1 22200.2 1.67936e+07 1732.9 1.25993e+07 6367.64 1.67936e+07 6476.2 6.30784e+06 1746.64 1.05021e+07 1435.43 1.05021e+07 1430.1 1.05021e+07 832212 1.17826e+06 8.154e+06 3.08671e+07

images

@achamayou achamayou merged commit e5c5fe3 into microsoft:main Aug 11, 2023
@achamayou achamayou added auto-backport Automatically backport this PR to LTS branch 4.x-todo PRs which should be backported to 4.x labels Sep 11, 2023
@ghost
Copy link

ghost commented Sep 11, 2023

💔 All backports failed

Status Branch Result
❌ release/4.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 5533

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@achamayou achamayou mentioned this pull request Sep 11, 2023
Merged
achamayou added a commit to achamayou/CCF that referenced this pull request Sep 11, 2023
@achamayou
Remove our copy of attestation container now that it has moved repos (m…
dd31412 
…icrosoft#5533)

(cherry picked from commit e5c5fe3)

# Conflicts:
#	.azure-pipelines-templates/configure.yml
#	attestation-container/go.mod
#	attestation-container/go.sum
#	scripts/azure_deployment/arm_aci.py
#	tests/external_executor/executors/ccf/executors/registration.py
@achamayou achamayou added the backported This PR was successfully backported to LTS branch label Sep 11, 2023
@ghost ghost mentioned this pull request Sep 14, 2023
Merged
achamayou added a commit that referenced this pull request Sep 15, 2023
@achamayou
[release/4.x] Cherry pick: Remove our copy of attestation container n…
b803fe5 
…ow that it has moved repos (#5533) (#5648)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumaffre jumaffre jumaffre approved these changes

@eddyashton eddyashton eddyashton approved these changes

Assignees
No one assigned
Labels
4.x-todo PRs which should be backported to 4.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

De-duplicate attestation container code, CI and release infrastructure
3 participants
@achamayou @eddyashton @jumaffre