Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEV-SNP: Make UVM endorsements SVN an arbitrary string #5620

Merged
merged 6 commits into from
Sep 5, 2023
Merged

SEV-SNP: Make UVM endorsements SVN an arbitrary string #5620

merged 6 commits into from
Sep 5, 2023

Conversation

jumaffre
Copy link
Contributor

@jumaffre jumaffre commented Sep 5, 2023

This is because the format for this SVN is not yet publicly defined.

@jumaffre jumaffre requested a review from a team September 5, 2023 14:54
@achamayou
Copy link
Member

@jumaffre needs a formatter run

@jumaffre jumaffre added auto-backport Automatically backport this PR to LTS branch 4.x-todo PRs which should be backported to 4.x labels Sep 5, 2023
@ghost
Copy link

ghost commented Sep 5, 2023

snp_disable_svn@75392 aka 20230905.34 vs main ewma over 20 builds from 75068 to 75360

Click to see table

main

build_id build_number Commit latency factor ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem pi_basic_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_basic_js_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem pi_basic_mt_virtual_cft^ hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem
75068 20230829.16 0.809401 16463.6 1.88908e+07 16642.3 1.05021e+07 18229.3 1.46964e+07 43726.9 47123.4 1660.5 1.25993e+07 52605.2 8110.87 1.88908e+07 4454.9 8029.2 6.30784e+06 17049.5 18922.9 6677.58 1.67936e+07 17176.5 14701.2 6589.89 1.67936e+07 9835.02 4544.74 1.67936e+07 74613.9 45028.8 827273 1.1834e+06 8.17271e+06 3.04368e+07 31745.1 2.51822e+07
75075 20230830.2 0.83702 16563.8 1.88908e+07 16654.7 1.05021e+07 18189.3 1.46964e+07 43456.6 46733.1 1657.2 1.25993e+07 52213.1 8167.29 1.88908e+07 4398.3 8230.5 6.30784e+06 17014 19070.9 7047.25 1.67936e+07 17062.6 16817.8 6593.9 1.67936e+07 9974.4 4554.07 1.88908e+07 86648.2 45484.8 826908 1.18068e+06 8.15254e+06 3.11507e+07 31443.3 2.51822e+07
75118 20230830.13 0.795668 16491 1.88908e+07 16680 1.05021e+07 18051 1.46964e+07 45593.2 48059.4 1663.1 1.25993e+07 52813.5 8112.14 1.88908e+07 4457.8 7954.1 6.30784e+06 17349.4 20106.6 7033.9 1.67936e+07 17373.9 14942.4 6580.25 1.67936e+07 9804.35 4552.79 1.88908e+07 72874.4 47358.5 832726 1.18129e+06 8.14764e+06 3.08745e+07 31938.4 2.51822e+07
75138 20230831.1 0.773449 16645.3 1.88908e+07 16771.3 1.05021e+07 18311.5 1.46964e+07 43630.2 47411.3 1663 1.25993e+07 52119.9 8210.87 1.88908e+07 4397.6 8101.1 6.30784e+06 17082.2 19267.5 7084.23 1.67936e+07 17317.9 14683.8 6583.37 1.67936e+07 10262.5 4562.01 1.88908e+07 79560.7 44903.6 830487 1.17891e+06 8.16955e+06 3.07873e+07 31562.4 2.51822e+07
75147 20230831.5 0.8359 16620.2 1.88908e+07 16630.1 1.05021e+07 18144.9 1.46964e+07 45573.1 48177.4 1666.7 1.25993e+07 52131.9 8196.8 1.88908e+07 4405.6 8057.8 6.30784e+06 17303.2 19827.5 7048.63 1.67936e+07 17369.8 14758.6 6608.94 1.67936e+07 9891.05 4562.55 1.88908e+07 81401.7 41701.5 830948 1.18148e+06 8.15446e+06 3.0816e+07 31681.2 2.51822e+07
75161 20230831.13 0.81577 16612.1 1.88908e+07 16689.8 1.05021e+07 18176.9 1.46964e+07 45571.9 47766.7 1662.5 1.25993e+07 53718.3 8177.4 1.88908e+07 4503 8247.9 6.30784e+06 17400.8 19874 7057.42 1.67936e+07 17702.4 14986 6656.13 1.67936e+07 9882.54 4592.61 1.88908e+07 76022.4 45490.8 835212 1.18234e+06 8.14249e+06 3.10944e+07 31568.6 2.51822e+07
75179 20230901.1 0.797232 16579.7 1.88908e+07 16750.6 1.05021e+07 18260.6 1.46964e+07 45657.3 47855.8 1651.5 1.25993e+07 53488.1 8210.63 1.88908e+07 4495.8 8323.5 6.30784e+06 17477.4 19934.6 7118.74 1.67936e+07 17505.9 16835.2 6616.41 1.67936e+07 9785.78 4612.34 1.88908e+07 71122.1 41584.1 825699 1.17706e+06 8.1735e+06 3.05134e+07 31914.7 2.51822e+07
75187 20230901.5 0.766884 16587 1.88908e+07 16666.6 1.05021e+07 18204.9 1.46964e+07 45662.6 48325.3 1664.1 1.25993e+07 53440.6 8202.09 1.88908e+07 4512.9 8078 6.30784e+06 17221 19316.2 6682.26 1.67936e+07 17486.5 14957.1 6598.69 1.67936e+07 9967.15 4583.19 1.88908e+07 76743.7 45560.3 827788 1.17683e+06 8.15403e+06 3.07134e+07 31852.3 2.51822e+07
75221 20230901.20 0.806705 16540.9 1.88908e+07 16657.1 1.05021e+07 18199.7 1.25993e+07 45841.2 46657 1658.8 1.25993e+07 51767.4 8186.95 1.88908e+07 4441.4 8391.7 6.30784e+06 17067.9 19837.3 7065.59 1.67936e+07 17273 14959.9 6636.06 1.67936e+07 9904.99 4580.72 1.88908e+07 67827.1 45518.4 836676 1.1816e+06 8.10531e+06 3.06734e+07 32113.1 2.51822e+07
75234 20230901.26 0.799024 16412 1.88908e+07 16520.2 1.05021e+07 18034.1 1.46964e+07 45763 48415.1 1640.1 1.25993e+07 52445.3 8046.24 1.88908e+07 4461.9 7975.8 6.30784e+06 17320.3 19267.1 6617.55 1.67936e+07 17307.8 16727 6583.32 1.67936e+07 9900.84 4562.49 1.88908e+07 81323.7 47832.7 814140 1.17862e+06 8.11427e+06 3.09824e+07 31298.5 2.51822e+07
75255 20230904.2 0.800459 16585.1 1.88908e+07 16649.8 1.05021e+07 18179.8 1.46964e+07 45618.4 47656 1659.1 1.25993e+07 52809.9 8133.32 1.88908e+07 4482.3 8318.8 6.30784e+06 17231.3 19040.4 7070.58 1.67936e+07 15210.2 16875 6589.49 1.67936e+07 9795.68 4555.83 1.88908e+07 70284.9 50413 834549 1.18199e+06 8.15296e+06 3.13879e+07 31877.2 2.51822e+07
75265 20230904.6 0.797237 16561.7 1.88908e+07 16683.7 1.05021e+07 18219.1 1.46964e+07 45627.4 48343.5 1658 1.25993e+07 52792.7 8180.61 1.88908e+07 4465.8 8300.5 6.30784e+06 17315 19935.4 7057.78 1.67936e+07 17552.3 15100.5 6644.72 1.67936e+07 9851.17 4583.56 1.88908e+07 63213.7 45461.7 831805 1.17771e+06 8.15034e+06 3.12653e+07 31457.4 2.51822e+07
75271 20230904.8 0.807553 16703.8 1.88908e+07 16797.4 1.05021e+07 18353.3 1.46964e+07 45699.4 48066.8 1655.8 1.25993e+07 54336.2 8200.03 1.88908e+07 4468.2 8097.4 6.30784e+06 17313.8 19411.1 7074.81 1.67936e+07 16926.8 14815 6593.84 1.67936e+07 9820.68 4556.21 1.88908e+07 78961.1 45397.8 839817 1.18163e+06 8.15446e+06 3.10369e+07 32193.1 2.51822e+07
75282 20230904.12 0.796235 16694.9 1.88908e+07 16916.6 1.05021e+07 18325.5 1.46964e+07 45690.9 49077.3 1648.6 1.25993e+07 54125.9 8156.02 1.88908e+07 4479.4 7968.6 6.30784e+06 17623.4 16298.1 7040.55 1.67936e+07 17113.3 14553.5 6637.16 1.67936e+07 9824.1 4557.13 1.88908e+07 79345.1 48180.1 834932 1.18089e+06 8.15433e+06 3.07392e+07 31979.1 2.51822e+07
75288 20230904.14 0.801078 16679.2 1.88908e+07 16871.4 1.05021e+07 18477.5 1.46964e+07 45797.3 47838.9 1656.9 1.25993e+07 53668.7 8152.93 1.88908e+07 4491.1 8019.1 6.30784e+06 17414.1 19684.7 7036.64 1.67936e+07 17347 14843.7 6584.04 1.67936e+07 9878.27 4551.27 1.88908e+07 80429.9 44845.8 830898 1.18237e+06 8.1505e+06 3.0772e+07 32335.9 2.51822e+07
75300 20230905.1 0.770774 16645.6 1.88908e+07 16823.7 1.05021e+07 18313.7 1.46964e+07 45506.3 48842.4 1652.3 1.25993e+07 53087.4 8180.27 1.88908e+07 4485.3 8177 6.30784e+06 17474.3 19306.5 7051.17 1.67936e+07 17442.8 15046.5 6596.68 1.67936e+07 9898.89 4571.26 1.88908e+07 79372.1 50271.9 821926 1.1746e+06 8.1143e+06 3.17018e+07 32207.2 2.51822e+07
75314 20230905.8 0.820898 16738.7 1.88908e+07 16868.1 1.05021e+07 18392.4 1.46964e+07 45656.7 48164.7 1648.2 1.25993e+07 53451 8201.26 1.88908e+07 4387.1 8305.8 6.30784e+06 17378.6 19385.9 7067.89 1.67936e+07 17350.5 14763.3 6593.78 1.67936e+07 10113.2 4587.48 1.88908e+07 71193 45347.1 830368 1.17868e+06 8.15579e+06 3.08615e+07 32224.6 2.51822e+07
75332 20230905.15 0.795074 16686.1 1.88908e+07 16806.5 1.05021e+07 18374.4 1.46964e+07 45805 48010.4 1663.1 1.25993e+07 53472.6 8145.3 1.88908e+07 4468.6 8056.1 6.30784e+06 17303.8 19203.1 7062.03 1.67936e+07 17495.4 14979.2 6644.82 1.67936e+07 9760 4549.04 1.88908e+07 73261.1 47860 830160 1.17693e+06 8.15631e+06 3.07813e+07 32237.6 2.51822e+07
75348 20230905.21 0.818926 16897 1.88908e+07 16860.5 1.05021e+07 18475.4 1.46964e+07 45750.9 48204.9 1657.2 1.25993e+07 52524 8211.83 1.88908e+07 4466 8045.4 6.30784e+06 17413.2 19456.4 7058.49 1.67936e+07 17519 15001.3 6594.25 1.67936e+07 10200.3 4559.4 1.88908e+07 69941.9 43975.4 820294 1.17696e+06 8.17128e+06 3.07581e+07 31697 2.51822e+07
75360 20230905.26 0.800555 16639.2 1.88908e+07 16865.9 1.05021e+07 18094.7 1.46964e+07 45554.4 42866.8 1629.4 1.25993e+07 51334.5 8097.92 1.88908e+07 4480 8244.9 6.30784e+06 17462.1 19193.1 6577.72 1.67936e+07 16930.1 15179.2 6573.38 1.67936e+07 9898.05 4545.58 1.67936e+07 75493.7 47617.4 834158 1.17952e+06 8.1542e+06 3.0816e+07 32429.6 2.51822e+07

snp_disable_svn

build_id build_number pi_basic_mt_virtual_cft^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem Commit latency factor ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_basic_js_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem hist_sgx_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
75392 20230905.34 80530.1 31570.5 2.51822e+07 0.790617 44054.7 43947.4 54227.7 16914.2 1.88908e+07 4413.7 16876.4 1.05021e+07 18270.7 1.46964e+07 17425.8 19436 17082.5 14451.9 9757.72 1654.8 1.25993e+07 8186.63 1.88908e+07 8028.5 6.30784e+06 7037.93 1.67936e+07 6574.56 1.67936e+07 45196.8 4585.53 1.88908e+07 837267 1.17851e+06 8.1541e+06 3.10628e+07

images

@jumaffre jumaffre merged commit c49ca85 into microsoft:main Sep 5, 2023
@ghost ghost mentioned this pull request Sep 6, 2023
Merged
@jumaffre jumaffre mentioned this pull request Sep 6, 2023
Merged
jumaffre added a commit to jumaffre/CCF that referenced this pull request Sep 6, 2023
@jumaffre
SEV-SNP: Make UVM endorsements SVN an arbitrary string (microsoft#5620)
f8d13a5 
(cherry picked from commit c49ca85)

# Conflicts:
#	.snpcc_canary
#	CHANGELOG.md
#	doc/schemas/gov_openapi.json
#	src/node/rpc/member_frontend.h
@jumaffre jumaffre added the backported This PR was successfully backported to LTS branch label Sep 6, 2023
jumaffre added a commit that referenced this pull request Sep 6, 2023
@jumaffre
[release/4.x] Cherry pick: SEV-SNP: Make UVM endorsements SVN an arbi…
cc50148 
…trary string (#5620) (#5627)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achamayou achamayou achamayou approved these changes

Assignees
No one assigned
Labels
4.x-todo PRs which should be backported to 4.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jumaffre @achamayou