-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore use of -lvi-cfg
variants of OE libs
#5635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumaffre
added
auto-backport
Automatically backport this PR to LTS branch
4.x-todo
PRs which should be backported to 4.x
labels
Sep 8, 2023
jumaffre
approved these changes
Sep 8, 2023
I think it's time to add a test that parses the output of ninja -v and checks that the right flags are passed to every compiler invocation, and the right variant of the libraries are linked. |
oe_lvi_2@75590 aka 20230908.6 vs main ewma over 20 builds from 75265 to 75585 Click to see tablemain
oe_lvi_2
|
Merged
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
jumaffre
pushed a commit
to jumaffre/CCF
that referenced
this pull request
Sep 11, 2023
(cherry picked from commit a62f7bf) # Conflicts: # cmake/open_enclave.cmake
achamayou
pushed a commit
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4.x-todo
PRs which should be backported to 4.x
auto-backport
Automatically backport this PR to LTS branch
backported
This PR was successfully backported to LTS branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upgrade to OE 0.19, we moved to building with Clang 11 so the LVI mitigation solution changed -
-mlvi-cfi
rather than a custom toolchain. In the process, we began linking against the unmitigated OE libs.