Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore use of -lvi-cfg variants of OE libs #5635

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

eddyashton
Copy link
Member

In the upgrade to OE 0.19, we moved to building with Clang 11 so the LVI mitigation solution changed - -mlvi-cfi rather than a custom toolchain. In the process, we began linking against the unmitigated OE libs.

@eddyashton eddyashton requested a review from a team September 8, 2023 08:59
@jumaffre jumaffre added auto-backport Automatically backport this PR to LTS branch 4.x-todo PRs which should be backported to 4.x labels Sep 8, 2023
@achamayou
Copy link
Member

I think it's time to add a test that parses the output of ninja -v and checks that the right flags are passed to every compiler invocation, and the right variant of the libraries are linked.

@ghost
Copy link

ghost commented Sep 8, 2023

oe_lvi_2@75590 aka 20230908.6 vs main ewma over 20 builds from 75265 to 75585

Click to see table

main

build_id build_number Commit latency factor pi_basic_mt_virtual_cft^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_jwt_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem hist_sgx_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
75265 20230904.6 0.797237 63213.7 31457.4 2.51822e+07 45627.4 48343.5 52792.7 4465.8 17315 16561.7 1.88908e+07 19935.4 16683.7 1.05021e+07 18219.1 1.46964e+07 17552.3 15100.5 9851.17 1658 1.25993e+07 8180.61 1.88908e+07 8300.5 6.30784e+06 45461.7 7057.78 1.67936e+07 6644.72 1.67936e+07 4583.56 1.88908e+07 831805 1.17771e+06 8.15034e+06 3.12653e+07
75271 20230904.8 0.807553 78961.1 32193.1 2.51822e+07 45699.4 48066.8 54336.2 4468.2 17313.8 16703.8 1.88908e+07 19411.1 16797.4 1.05021e+07 18353.3 1.46964e+07 16926.8 14815 9820.68 1655.8 1.25993e+07 8200.03 1.88908e+07 8097.4 6.30784e+06 45397.8 7074.81 1.67936e+07 6593.84 1.67936e+07 4556.21 1.88908e+07 839817 1.18163e+06 8.15446e+06 3.10369e+07
75282 20230904.12 0.796235 79345.1 31979.1 2.51822e+07 45690.9 49077.3 54125.9 4479.4 17623.4 16694.9 1.88908e+07 16298.1 16916.6 1.05021e+07 18325.5 1.46964e+07 17113.3 14553.5 9824.1 1648.6 1.25993e+07 8156.02 1.88908e+07 7968.6 6.30784e+06 48180.1 7040.55 1.67936e+07 6637.16 1.67936e+07 4557.13 1.88908e+07 834932 1.18089e+06 8.15433e+06 3.07392e+07
75288 20230904.14 0.801078 80429.9 32335.9 2.51822e+07 45797.3 47838.9 53668.7 4491.1 17414.1 16679.2 1.88908e+07 19684.7 16871.4 1.05021e+07 18477.5 1.46964e+07 17347 14843.7 9878.27 1656.9 1.25993e+07 8152.93 1.88908e+07 8019.1 6.30784e+06 44845.8 7036.64 1.67936e+07 6584.04 1.67936e+07 4551.27 1.88908e+07 830898 1.18237e+06 8.1505e+06 3.0772e+07
75300 20230905.1 0.770774 79372.1 32207.2 2.51822e+07 45506.3 48842.4 53087.4 4485.3 17474.3 16645.6 1.88908e+07 19306.5 16823.7 1.05021e+07 18313.7 1.46964e+07 17442.8 15046.5 9898.89 1652.3 1.25993e+07 8180.27 1.88908e+07 8177 6.30784e+06 50271.9 7051.17 1.67936e+07 6596.68 1.67936e+07 4571.26 1.88908e+07 821926 1.1746e+06 8.1143e+06 3.17018e+07
75314 20230905.8 0.820898 71193 32224.6 2.51822e+07 45656.7 48164.7 53451 4387.1 17378.6 16738.7 1.88908e+07 19385.9 16868.1 1.05021e+07 18392.4 1.46964e+07 17350.5 14763.3 10113.2 1648.2 1.25993e+07 8201.26 1.88908e+07 8305.8 6.30784e+06 45347.1 7067.89 1.67936e+07 6593.78 1.67936e+07 4587.48 1.88908e+07 830368 1.17868e+06 8.15579e+06 3.08615e+07
75332 20230905.15 0.795074 73261.1 32237.6 2.51822e+07 45805 48010.4 53472.6 4468.6 17303.8 16686.1 1.88908e+07 19203.1 16806.5 1.05021e+07 18374.4 1.46964e+07 17495.4 14979.2 9760 1663.1 1.25993e+07 8145.3 1.88908e+07 8056.1 6.30784e+06 47860 7062.03 1.67936e+07 6644.82 1.67936e+07 4549.04 1.88908e+07 830160 1.17693e+06 8.15631e+06 3.07813e+07
75348 20230905.21 0.818926 69941.9 31697 2.51822e+07 45750.9 48204.9 52524 4466 17413.2 16897 1.88908e+07 19456.4 16860.5 1.05021e+07 18475.4 1.46964e+07 17519 15001.3 10200.3 1657.2 1.25993e+07 8211.83 1.88908e+07 8045.4 6.30784e+06 43975.4 7058.49 1.67936e+07 6594.25 1.67936e+07 4559.4 1.88908e+07 820294 1.17696e+06 8.17128e+06 3.07581e+07
75360 20230905.26 0.800555 75493.7 32429.6 2.51822e+07 45554.4 42866.8 51334.5 4480 17462.1 16639.2 1.88908e+07 19193.1 16865.9 1.05021e+07 18094.7 1.46964e+07 16930.1 15179.2 9898.05 1629.4 1.25993e+07 8097.92 1.88908e+07 8244.9 6.30784e+06 47617.4 6577.72 1.67936e+07 6573.38 1.67936e+07 4545.58 1.67936e+07 834158 1.17952e+06 8.1542e+06 3.0816e+07
75413 20230905.41 0.822033 84700.2 32149.1 2.51822e+07 42002.8 47678.8 53684.4 4426.7 17180.1 16619.4 1.88908e+07 19169.9 16634.2 1.05021e+07 18150.8 1.46964e+07 17447.2 14839.1 10272.6 1640.4 1.25993e+07 8128.27 1.88908e+07 7918 6.30784e+06 46378.9 6668.1 1.67936e+07 6561.8 1.67936e+07 4544.2 1.67936e+07 831657 1.18593e+06 8.15381e+06 3.25544e+07
75427 20230905.45 0.79923 72646.1 32303 2.51822e+07 43818.6 47219.3 54172.4 4474.6 17207 16851.9 1.88908e+07 20035.7 16843.5 1.05021e+07 18380.2 1.46964e+07 17125.1 16863.6 9757.72 1660.9 1.25993e+07 8204.56 1.88908e+07 8033.3 6.30784e+06 49899.7 7055.71 1.67936e+07 6604.32 1.67936e+07 4591.15 1.88908e+07 831718 1.18507e+06 8.16148e+06 3.07891e+07
75432 20230906.1 0.792911 72254 32134 2.72794e+07 44002.6 47749.6 54054.4 4440.1 17184.3 16953.5 1.88908e+07 19123.7 16886.8 1.05021e+07 18426.2 1.46964e+07 17476.7 14970.7 10416.6 1656.7 1.25993e+07 8197.08 1.88908e+07 8067.4 6.30784e+06 47511.8 7062.48 1.67936e+07 6650.18 1.67936e+07 4558.5 1.88908e+07 836786 1.17882e+06 8.13596e+06 3.09679e+07
75453 20230906.8 0.786039 62844.4 31842.2 2.51822e+07 45758.2 48251.8 54707.9 4474.7 17380.4 16911.9 1.88908e+07 18840.6 16854.2 1.05021e+07 18339 1.46964e+07 17589.3 14994.8 9887.4 1666.3 1.25993e+07 8195.46 1.88908e+07 8236.7 6.30784e+06 47836.8 7050.11 1.67936e+07 6651.5 1.67936e+07 4550.56 1.88908e+07 831787 1.17789e+06 8.12511e+06 3.08063e+07
75489 20230906.23 0.800124 82560 31743.9 2.51822e+07 43804.6 47435.6 54050.3 4459.5 17073.3 16654.9 1.88908e+07 18929 16776.6 1.05021e+07 18256.7 1.25993e+07 17464.5 14865.8 10073.8 1636.7 1.25993e+07 8153.42 1.88908e+07 8125.5 6.30784e+06 49990.9 6677.29 1.67936e+07 6628.14 1.67936e+07 4550.28 1.88908e+07 835269 1.17747e+06 8.13363e+06 3.07143e+07
75522 20230907.3 0.772057 66260.1 32075.6 2.51822e+07 45714.3 48111.2 54314.5 4463.3 17295.6 16673.7 1.88908e+07 19589.4 16929.9 1.05021e+07 18283.4 1.46964e+07 17065.4 14677.8 10062.2 1656.8 1.25993e+07 8168.97 1.88908e+07 8023.9 6.30784e+06 49662.8 7052.03 1.67936e+07 6594.49 1.67936e+07 4565.33 1.88908e+07 828056 1.18636e+06 8.1552e+06 3.07808e+07
75527 20230907.5 0.781303 86171.1 32308 2.51822e+07 43523 47340.4 53737.5 4404.9 17097.4 16807.7 1.88908e+07 19462.4 16890.6 1.05021e+07 18259.9 1.46964e+07 17630.6 15065 10283.8 1648.4 1.25993e+07 8151.7 1.88908e+07 7992.3 6.30784e+06 42500.3 7014.17 1.67936e+07 6599.19 1.67936e+07 4558.03 1.88908e+07 823830 1.18114e+06 8.1554e+06 3.07249e+07
75554 20230907.14 0.784733 89286.5 32296.2 2.51822e+07 45865.6 47959.1 54950.9 4492.7 17191.6 16776.5 1.88908e+07 19221.2 16911.3 1.05021e+07 18490.9 1.46964e+07 17286.2 16906.8 9966.44 1659.7 1.25993e+07 8214.84 1.88908e+07 8100.2 6.30784e+06 47720.1 7060.74 1.67936e+07 6600.24 1.67936e+07 4579.56 1.88908e+07 832953 1.17863e+06 8.1447e+06 3.05827e+07
75570 20230907.20 0.799646 62416.2 32177.9 2.51822e+07 45705.3 48300.1 55108.2 4494.8 17134.4 16832.6 1.88908e+07 19570.6 17001.3 1.05021e+07 18451.6 1.46964e+07 17098.8 16872.1 9890.69 1661.9 1.25993e+07 8246.8 1.88908e+07 8192.6 6.30784e+06 46267.7 7051.77 1.67936e+07 6608.3 1.67936e+07 4556.94 1.88908e+07 831516 1.18245e+06 8.13564e+06 3.11644e+07
75578 20230908.2 0.828259 78823.5 32091.1 2.51822e+07 43942.1 48082.5 54705.4 4443.4 17216 16699.5 1.88908e+07 18878.3 16847.4 1.05021e+07 18400.6 1.46964e+07 17041.1 16926.4 9811.7 1654.5 1.25993e+07 8136.67 1.88908e+07 8377.3 6.30784e+06 48501.8 7061.63 1.67936e+07 6591.31 1.67936e+07 4554.19 1.88908e+07 833497 1.1874e+06 8.15413e+06 3.08021e+07
75585 20230908.5 0.797482 74515.3 32334.7 2.51822e+07 43449.2 48049.2 54134.4 4445.7 16982.9 16880.3 1.88908e+07 19441.6 16912.1 1.05021e+07 18498.4 1.25993e+07 17178.3 14747.2 10169.7 1654.4 1.25993e+07 8214.32 1.88908e+07 8178.3 6.30784e+06 48501 6689.4 1.67936e+07 6602.85 1.67936e+07 4556.48 1.88908e+07 840060 1.18261e+06 8.15384e+06 3.08624e+07

oe_lvi_2

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem Commit latency factor pi_basic_mt_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_basic_js_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_jwt_virtual_cft^ pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
75590 20230908.6 27149.5 2.30851e+07 0.806166 70772 45535.5 48254.9 51151.3 13926.7 1.88908e+07 4503.8 13967.1 1.05021e+07 17254.1 15482.2 1.46964e+07 19614.4 17307.3 14836.1 9934.22 1448.8 1.25993e+07 6811.23 1.88908e+07 7092.6 6.30784e+06 5746.34 1.67936e+07 42425.6 5447.64 1.67936e+07 3987.81 1.67936e+07 839641 1.1716e+06 8.17428e+06 3.14183e+07

images

@achamayou achamayou mentioned this pull request Sep 8, 2023
@achamayou achamayou merged commit a62f7bf into microsoft:main Sep 8, 2023
21 checks passed
@ghost
Copy link

ghost commented Sep 8, 2023

💔 All backports failed

Status Branch Result
release/4.x Backport failed because of merge conflicts

You might need to backport the following PRs to release/4.x:
- OpenSSL3: remove use of deprecated functions (#5481)

Manual backport

To create the backport manually run:

backport --pr 5635

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@jumaffre jumaffre added the backported This PR was successfully backported to LTS branch label Sep 11, 2023
jumaffre pushed a commit to jumaffre/CCF that referenced this pull request Sep 11, 2023
(cherry picked from commit a62f7bf)

# Conflicts:
#	cmake/open_enclave.cmake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x-todo PRs which should be backported to 4.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants