Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/4.x] Cherry pick: Discard malformed traffic sent to node-to-node ports (#5889) #5900

Merged
merged 1 commit into from
Jan 9, 2024
Merged

[release/4.x] Cherry pick: Discard malformed traffic sent to node-to-node ports (#5889) #5900

merged 1 commit into from
Jan 9, 2024

Conversation

achamayou
Copy link
Member

Backports the following commits to release/4.x:

@eddyashton
Discard malformed traffic sent to node-to-node ports (microsoft#5889)
7d444ae 
(cherry picked from commit e618e51)

# Conflicts:
#	CHANGELOG.md
@achamayou achamayou requested a review from a team January 9, 2024 09:37
@achamayou achamayou added the 4.x-backport Highlights PRs targeting the 4.x branch label Jan 9, 2024
@achamayou achamayou enabled auto-merge (squash) January 9, 2024 09:37
@ghost
Copy link

ghost commented Jan 9, 2024

backport/release/4.x/pr-5889@80037 aka 20240109.9 vs release/4.x ewma over 20 builds from 79419 to 80022

Click to see table

release/4.x

build_id build_number Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ ls_jwt_virtual_cft^ hist_sgx_cft^ pi_ls_jwt_virtual_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^
79419 20231213.4 0.797291 5605.18 8.59996e+07 14083.6 1.67936e+07 14221.6 1.05021e+07 6808.11 1.67936e+07 7176.4 6.30784e+06 1461.75 1.05021e+07 1212.44 1.05021e+07 1285.99 1.05021e+07 17395.3 45640.4 47756.2 17007.6 46413.4 19128.1 830169 1.18045e+06 8.1552e+06 3.17387e+07 4406.13 3453.61 3781.79
79456 20231214.4 0.787291 5541.76 8.59996e+07 14027.2 1.88908e+07 14149.1 1.05021e+07 7247.37 1.67936e+07 7181 6.30784e+06 1450.97 1.05021e+07 1202.36 1.05021e+07 1293.47 1.05021e+07 17099.2 45795.6 47090.8 17515.7 40166.7 19048.3 828934 1.16939e+06 8.15517e+06 3.07475e+07 4388.15 3441.5 3618.75
79469 20231215.4 0.784482 5605.85 8.59996e+07 14046.7 1.88908e+07 14201.8 1.05021e+07 7264.35 1.67936e+07 7183.8 6.30784e+06 1461.43 1.05021e+07 1214.67 1.05021e+07 1286.74 1.05021e+07 17126.8 45909.6 46658.1 17060.4 45323 19333.8 830530 1.181e+06 8.15339e+06 3.08476e+07 4398.27 3439.98 3739.53
79503 20231218.4 0.800476 5612.77 8.59996e+07 14047.2 1.88908e+07 14222.7 1.05021e+07 6866.6 1.88908e+07 7202.1 6.30784e+06 1462.08 1.05021e+07 1215.08 1.05021e+07 1288.79 1.05021e+07 17428 45579.6 47523.8 17113.3 47538.6 19033.1 814596 1.16123e+06 8.1552e+06 3.27449e+07 4386.97 3463.79 3614.94
79571 20231219.4 0.775899 5584.7 8.59996e+07 14094.5 1.88908e+07 14194.5 1.05021e+07 7208.18 1.67936e+07 7199.1 6.30784e+06 1458.12 1.05021e+07 1211.7 1.05021e+07 1301.45 1.05021e+07 17146 45695.8 47260.8 17071.4 44561.9 19418.6 839958 1.1789e+06 8.15309e+06 3.07415e+07 4393.57 3451.85 3629.53
79641 20231220.3 0.770398 5612.41 8.59996e+07 14133.7 1.88908e+07 14215.6 1.05021e+07 7245.71 1.67936e+07 7200.5 6.30784e+06 1463.5 1.05021e+07 1221.2 1.05021e+07 1303.61 1.05021e+07 17149.5 45498.4 46956.1 17540.7 43590.6 19297.2 843036 1.17401e+06 8.15416e+06 3.08067e+07 4416.22 3460.88 3772.99
79698 20231221.5 0.805021 5581.83 8.59996e+07 14045.7 1.88908e+07 14193.1 1.05021e+07 7265.93 1.67936e+07 7208.9 6.30784e+06 1457.49 1.05021e+07 1197.94 1.05021e+07 1279.44 1.05021e+07 17388 45588.6 47392.7 17162.9 47557.5 19405 836480 1.18361e+06 8.15322e+06 3.10647e+07 4275.87 3441.42 3755.27
79709 20231222.4 0.774721 5623.15 8.59996e+07 14013.5 1.88908e+07 14202.3 1.05021e+07 6878.86 1.88908e+07 7209.8 6.30784e+06 1445.95 1.05021e+07 1211.2 1.05021e+07 1290.08 1.05021e+07 17751.7 43620.6 47092.7 17334.1 45232.8 19158.2 829755 1.18259e+06 8.15342e+06 3.07447e+07 4408.5 3470.3 3780.16
79728 20231225.4 0.79635 5598.67 8.59996e+07 14113.7 1.88908e+07 14191.2 1.05021e+07 7270.68 1.67936e+07 7195.7 6.30784e+06 1459.17 1.05021e+07 1207.1 1.05021e+07 1288.31 1.05021e+07 17286.5 45748.3 47242.9 17116.1 43685.8 19048.3 830312 1.17855e+06 8.17144e+06 3.31735e+07 4254.73 3438.29 3639.07
79742 20231226.4 0.774202 5535.97 8.59996e+07 14032.7 1.88908e+07 14168 1.05021e+07 7244.35 1.67936e+07 7224.3 6.30784e+06 1449.4 1.05021e+07 1212.84 1.05021e+07 1294.52 1.05021e+07 17131.7 45603.1 47442.6 17222.3 44228.2 19487.5 830559 1.17842e+06 8.17209e+06 3.07489e+07 4385.62 3458.2 3643.29
79756 20231227.4 0.780467 5587.61 8.59996e+07 14053.2 1.88908e+07 14139.8 1.05021e+07 6865.54 1.88908e+07 7191.1 6.30784e+06 1457.22 1.05021e+07 1212.45 1.05021e+07 1293.97 1.05021e+07 17348.4 45511.6 47177.4 17250.5 38646.4 16218 833238 1.17851e+06 8.15485e+06 3.08308e+07 4427.76 3487.89 3772.69
79769 20231228.4 0.797127 5572.65 8.59996e+07 13970.4 1.88908e+07 14136.6 1.05021e+07 7233.35 1.67936e+07 7212.4 6.30784e+06 1448.26 1.05021e+07 1208.98 1.05021e+07 1292.54 1.05021e+07 17125.1 45690.8 47062.8 17129.2 45958.1 18623.3 836948 1.17924e+06 8.17216e+06 3.06225e+07 4267.17 3453.51 3624.16
79784 20231229.4 0.774826 5632.63 8.59996e+07 14048.1 1.88908e+07 14229.1 1.05021e+07 6879.08 1.88908e+07 7186 6.30784e+06 1458.97 1.05021e+07 1210.5 1.05021e+07 1286.76 1.05021e+07 17129.3 45705.5 47343.1 17115.2 46719.2 19398.6 823608 1.18111e+06 8.15537e+06 3.08657e+07 4407.97 3439.29 3777.71
79799 20240101.4 0.791338 5682.86 8.59996e+07 14090.1 1.67936e+07 14219.4 1.05021e+07 7283.39 1.67936e+07 7186.9 6.30784e+06 1461.21 1.05021e+07 1210.22 1.05021e+07 1302.76 1.05021e+07 17123.5 45560.2 47484.3 17024.9 45467.3 19052.6 834321 1.17409e+06 8.0445e+06 3.12533e+07 4352.79 3453.04 3738.32
79810 20240102.4 0.780573 5647.39 8.59996e+07 14039.7 1.88908e+07 14233.6 1.05021e+07 6865.96 1.67936e+07 7081.6 6.30784e+06 1458.94 1.05021e+07 1214.31 1.05021e+07 1287.99 1.05021e+07 17191.9 45803.9 47397.7 17220.6 46735.5 19042.6 839851 1.17419e+06 8.0397e+06 3.12576e+07 4376.95 3460.45 3621.18
79842 20240103.4 0.749664 5639.75 8.59996e+07 14071 1.67936e+07 14209.4 1.05021e+07 7260.13 1.88908e+07 7203.6 6.30784e+06 1459.85 1.05021e+07 1210.2 1.05021e+07 1288.91 1.05021e+07 17412.2 45556.2 47552.7 17104.1 47397.7 18598 836000 1.18122e+06 8.17304e+06 3.07037e+07 4411.23 3466.45 3638.86
79854 20240104.4 0.774933 5644.02 8.59996e+07 14095.2 1.88908e+07 14289.3 1.05021e+07 7300.41 1.67936e+07 7205.3 6.30784e+06 1464.13 1.05021e+07 1210.16 1.05021e+07 1301.15 1.05021e+07 17373.2 45839.5 47339.5 17267.1 42397 18995.2 834990 1.17653e+06 8.15254e+06 3.07604e+07 4253.96 3473.96 3645.22
79894 20240105.4 0.772702 5605.27 8.59996e+07 14043 1.88908e+07 14210.5 1.05021e+07 7232.22 1.88908e+07 7197.4 6.30784e+06 1459.36 1.05021e+07 1209.49 1.05021e+07 1285.24 1.05021e+07 17451.3 45541.1 47127.2 17421.9 45335.1 18618.5 831553 1.18456e+06 8.15212e+06 3.07526e+07 4413.55 3439.14 3794.87
79958 20240108.4 0.780353 5619.77 8.59996e+07 14055 1.88908e+07 14210.5 1.05021e+07 7256.02 1.67936e+07 7235.3 6.30784e+06 1457.89 1.05021e+07 1214.48 1.05021e+07 1288.55 1.05021e+07 17122.5 45627.5 47589.6 17209 44114.8 18841.2 830534 1.1735e+06 8.1515e+06 3.09361e+07 4280.03 3462.92 3628.64
80022 20240109.4 0.75993 5618.03 8.59996e+07 14044.2 1.88908e+07 14206.6 1.05021e+07 7254.86 1.67936e+07 7232.9 6.30784e+06 1460.42 1.05021e+07 1207.57 1.05021e+07 1288.8 1.05021e+07 17484.5 45582.3 47610.7 17344.7 39887.7 18682.5 832496 1.18016e+06 8.14813e+06 3.07231e+07 4408.16 3458.09 3613.81

backport/release/4.x/pr-5889

build_id build_number Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem hist_sgx_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
80037 20240109.9 0.79 5588.15 8.59996e+07 17310.5 45521.1 46831.8 14040 1.88908e+07 14183 1.05021e+07 17256 18822.9 7213.28 1.67936e+07 7145.9 6.30784e+06 4265.78 3470.65 3634.26 1443.59 1.05021e+07 1206.94 1.05021e+07 47668.2 1285.68 1.05021e+07 832173 1.18339e+06 8.15498e+06 3.12476e+07

images

@achamayou achamayou merged commit 6ddfb46 into microsoft:release/4.x Jan 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyashton eddyashton eddyashton approved these changes

Assignees
No one assigned
Labels
4.x-backport Highlights PRs targeting the 4.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achamayou @eddyashton