Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contains_globally_committed to kv::Set #5928

Merged
merged 5 commits into from
Jan 15, 2024

Conversation

eddyashton
Copy link
Member

Resolves #5926.

@eddyashton eddyashton requested a review from a team January 15, 2024 14:04
@ghost
Copy link

ghost commented Jan 15, 2024

add_contains_globally_committed@80374 aka 20240115.10 vs main ewma over 20 builds from 80094 to 80369

Click to see table

main

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem pi_basic_mt_virtual_cft^ tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ hist_sgx_cft^ pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ tlc_sim_traces tlc_sim_levelmean
80094 20240109.31 28085.6 2.51822e+07 6 77678 209 5.77852e+06 189 5.0742e+06 0.804231 5573.1 8.59996e+07 14090.2 1.88908e+07 14222.7 1.05021e+07 15634.2 1.46964e+07 1430.5 1.25993e+07 7275.45 1.67936e+07 6924.1 6.30784e+06 5816.35 1.67936e+07 5769.73 1.67936e+07 3988.35 1.67936e+07 87281.9 17297.9 53433.6 56694.8 62608 43765.3 4662.9 20736 836503 1.18123e+06 8.12931e+06 3.10449e+07 22087.2 20693.3 17701.3 11733.9 3819 403
80102 20240110.3 28155.1 2.30851e+07 5 77678 208 5.77852e+06 187 5.0742e+06 0.780749 5572.82 8.59996e+07 14058.8 1.88908e+07 14134.6 1.05021e+07 15597.1 1.25993e+07 1434.7 1.25993e+07 6839.89 1.67936e+07 7044.8 6.30784e+06 5808.17 1.67936e+07 5770.73 1.67936e+07 4010.45 1.67936e+07 83443.5 17241.8 55991.4 56950.9 62643.7 38972.7 4672.3 20523.6 835272 1.18135e+06 8.14959e+06 3.05868e+07 22367.9 21053.3 17212.3 11742.4 3518 403
80127 20240110.13 28361.2 2.51822e+07 5 77678 212 5.77852e+06 185 5.0742e+06 0.784593 5645.73 8.59996e+07 14108.3 1.88908e+07 14181.5 1.05021e+07 15726.7 1.46964e+07 1426.2 1.25993e+07 7227.32 1.67936e+07 6930.4 6.30784e+06 5814.49 1.67936e+07 5743.18 1.67936e+07 4000.68 1.67936e+07 67853.6 17254.6 52973.3 57229.8 62800.2 47054.2 4437.9 21029.2 830237 1.18158e+06 8.15485e+06 3.27345e+07 22247.4 20585.9 17535.4 11841 3470 403
80141 20240110.17 28010.7 2.30851e+07 6 77678 205 5.77852e+06 188 5.0742e+06 0.771918 5622.28 8.59996e+07 14075.7 1.88908e+07 14216.7 1.05021e+07 15540.4 1.25993e+07 1429.4 1.25993e+07 7266.46 1.67936e+07 7047.6 6.30784e+06 5772.12 1.67936e+07 5734.07 1.67936e+07 4000.46 1.67936e+07 89075.7 17271.4 55837.8 56631.9 63380.4 40664.8 4668.6 20687.5 829776 1.18296e+06 8.16646e+06 3.12634e+07 22707.1 17516.8 16919.7 11867.7 3490 403
80155 20240110.24 28137.6 2.51822e+07 6 77678 198 5.77852e+06 189 5.0742e+06 0.814507 5659.73 8.59996e+07 14138.6 1.88908e+07 14218.2 1.05021e+07 15669.6 1.46964e+07 1442.1 1.25993e+07 7262.24 1.67936e+07 6942 6.30784e+06 5809.87 1.67936e+07 5741.2 1.67936e+07 4012.82 1.67936e+07 68113.1 17255 55813.6 56715.1 64118.5 45787.2 4674.4 20532.4 838929 1.17924e+06 8.13816e+06 3.16832e+07 21497.1 20649.7 17579.3 11656.2 3465 403
80171 20240110.31 28060.1 2.51822e+07 6 77678 214 5.77852e+06 199 5.0742e+06 0.822009 5621.24 8.59996e+07 14139.3 1.88908e+07 14192.9 1.05021e+07 15625.4 1.25993e+07 1437.6 1.25993e+07 7231.89 1.67936e+07 7071.4 6.30784e+06 5765.58 1.67936e+07 5708.84 1.67936e+07 3972.77 1.67936e+07 68640.6 17265.5 53117.6 57097.5 62624.1 44417.4 4695.3 20449.4 830253 1.17919e+06 8.13473e+06 3.08592e+07 21597.3 20718.8 17607.1 11901.2 3623 403
80189 20240110.38 28036.9 2.51822e+07 6 77678 210 5.77852e+06 192 5.0742e+06 0.814313 5519.57 8.59996e+07 13980.4 1.88908e+07 14120.8 1.05021e+07 15465.4 1.25993e+07 1420.3 1.25993e+07 6814.45 1.88908e+07 7032.2 6.30784e+06 5793.73 1.67936e+07 5481.28 1.88908e+07 3988.62 1.67936e+07 93079.6 17149.1 53077.5 54544.7 62336.1 40070.9 4646.4 20502.6 835859 1.17563e+06 8.15576e+06 3.08592e+07 21532.2 20621 17438.8 11699.4 3568 403
80199 20240111.3 27513.6 2.51822e+07 6 77678 206 5.77852e+06 208 5.0742e+06 0.809202 5666.63 8.59996e+07 14088.4 1.88908e+07 14213.3 1.05021e+07 15681.5 1.25993e+07 1428.3 1.25993e+07 6929.44 1.88908e+07 7012.3 6.30784e+06 5761.89 1.67936e+07 5737.88 1.67936e+07 3974.98 1.67936e+07 77848.7 17246.8 55598.1 56861.2 62791.2 40635.8 4655 20613.2 828150 1.1829e+06 8.14418e+06 3.09702e+07 22275.7 17271.1 17041.5 11757.3 3603 403
80211 20240111.7 27977.8 2.30851e+07 6 77678 210 5.77852e+06 197 5.0742e+06 0.810097 5630.99 8.59996e+07 14065.3 1.67936e+07 14193.6 1.05021e+07 15697 1.46964e+07 1436.3 1.25993e+07 6866.88 1.67936e+07 6987.9 6.30784e+06 5770.52 1.67936e+07 5782.78 1.67936e+07 3985.43 1.67936e+07 94243.6 17215.8 53027.3 57220 60832.7 45045 4538.5 20877.2 820118 1.18458e+06 8.15585e+06 3.08174e+07 21639.4 17478.6 17282.2 11605.3 3424 403
80229 20240111.14 27955.9 2.30851e+07 6 77678 213 5.77852e+06 201 5.0742e+06 0.812835 5619.7 8.59996e+07 14056.2 1.67936e+07 14196 1.05021e+07 15573.5 1.46964e+07 1437.6 1.25993e+07 7262.24 1.88908e+07 7029.5 6.30784e+06 5814.66 1.67936e+07 5765.08 1.67936e+07 4000.28 1.67936e+07 81578.4 17111.2 50602.2 58236.4 61854.1 48116.8 4607.9 20912.3 831651 1.18093e+06 8.1541e+06 3.07406e+07 22219.8 17649.9 17429.6 11592.6 3780 403
80242 20240111.19 28203.5 2.51822e+07 6 77678 230 5.84821e+06 205 5.08533e+06 0.773804 5676 8.59996e+07 14015 1.88908e+07 14125.8 1.05021e+07 15610 1.46964e+07 1432.2 1.25993e+07 7227.55 1.67936e+07 6931.1 6.30784e+06 5774.13 1.67936e+07 5743.01 1.67936e+07 4011.12 1.67936e+07 80254.5 17179.2 52816.7 57165.1 61509 45142.8 4575.6 20626.3 824477 1.18539e+06 8.15543e+06 3.07813e+07 22255.9 17614.7 17469.5 11706.6 3496 403
80252 20240111.22 28090.5 2.51822e+07 6 77678 224 5.84821e+06 203 5.08533e+06 0.803418 5642.83 8.80968e+07 14130.4 1.88908e+07 14169.5 1.05021e+07 15696.8 1.25993e+07 1432.8 1.25993e+07 7272.8 1.67936e+07 7093.3 6.30784e+06 5808.84 1.67936e+07 5757.11 1.67936e+07 4009.22 1.67936e+07 96022.6 17226.9 55861.6 58346.8 62303.6 44845.1 4613.1 20686.4 830304 1.17589e+06 8.14596e+06 3.22312e+07 21550.3 17526.7 17350.6 11800.7 3419 403
80271 20240111.29 27607.9 2.30851e+07 6 77678 237 5.84821e+06 243 5.73663e+06 0.813292 5499.35 8.59996e+07 14036.4 1.88908e+07 14118.3 1.05021e+07 15562.4 1.25993e+07 1431 1.25993e+07 7241.94 1.67936e+07 7039.7 6.30784e+06 5815.33 1.67936e+07 5734.66 1.88908e+07 3971.63 1.67936e+07 83752.5 17133.9 55981.5 58573.4 62651.1 42971.6 4605.8 20476.2 831724 1.17891e+06 8.148e+06 3.07129e+07 22162.1 20610.2 17402.2 11766.9 3610 403
80281 20240111.33 27775 2.30851e+07 6 77678 229 5.84821e+06 252 5.73663e+06 0.807376 5593.57 8.59996e+07 14056.4 1.88908e+07 14156.9 1.05021e+07 15553.7 1.46964e+07 1429.4 1.25993e+07 7262.76 1.67936e+07 6942.1 6.30784e+06 5813.13 1.67936e+07 5740.59 1.88908e+07 3977.86 1.67936e+07 85969.9 17787.9 55910.9 57744.4 62780 47590.2 4629.4 20614.3 832607 1.18047e+06 8.15371e+06 3.07388e+07 21886.1 20606 17743.7 11816.4 3492 403
80292 20240112.1 28064.6 2.51822e+07 6 77678 237 5.84821e+06 254 5.73663e+06 0.799609 5616.54 8.59996e+07 14086 1.88908e+07 14203.3 1.05021e+07 15647.6 1.25993e+07 1431 1.25993e+07 7203.91 1.67936e+07 6980.4 6.30784e+06 5771.83 1.67936e+07 5724.94 1.67936e+07 4001.42 1.67936e+07 99762.3 17167.1 55981.2 58058.2 62225.6 40504.9 4625.2 20836.9 839107 1.17402e+06 8.13535e+06 3.10106e+07 22032.3 17710.9 17417.6 11589 3744 403
80302 20240112.6 28172.9 2.51822e+07 6 77678 231 5.84821e+06 255 5.73663e+06 0.825414 5106.83 8.80968e+07 14005.8 1.88908e+07 13959.4 1.05021e+07 15214.7 1.46964e+07 1411 1.25993e+07 6814.37 1.88908e+07 6972 6.30784e+06 5806.03 1.67936e+07 5435.01 1.67936e+07 3989.3 1.67936e+07 96165 17642.7 53235 57617.6 61515.4 39672.7 4588.4 21122.8 824006 1.17846e+06 8.13987e+06 3.0784e+07 21902.4 17823 17557.4 11576.2 3477 403
80310 20240112.9 28180.1 2.51822e+07 6 77678 232 5.84821e+06 249 5.73663e+06 0.777512 5489.82 8.59996e+07 13961.1 1.88908e+07 14164.5 1.05021e+07 15557.3 1.25993e+07 1433 1.25993e+07 6791.51 1.67936e+07 7052.7 6.30784e+06 5819.48 1.67936e+07 5501.69 1.88908e+07 4013.78 1.67936e+07 77692.7 17237.7 56197.8 58912.6 63019.4 45888.2 4550.4 20668.2 830922 1.1812e+06 8.13473e+06 3.09768e+07 22383.9 17474.6 17666.4 11810 3659 403
80334 20240112.19 28026.5 2.30851e+07 6 77678 232 5.84821e+06 240 5.73663e+06 0.79401 5651.76 8.59996e+07 14082.7 1.88908e+07 14160.5 1.05021e+07 15748.6 1.25993e+07 1438 1.05021e+07 7274 1.67936e+07 7082 6.30784e+06 5786 1.67936e+07 5772.55 1.67936e+07 3980.36 1.67936e+07 79466.5 17347.6 55964.3 58284.9 63911.7 45690 4653.1 20253.8 837432 1.17733e+06 8.15598e+06 3.19346e+07 22174.9 20908.6 17454 11706.5 3411 403
80350 20240115.1 27987.3 2.30851e+07 6 77678 234 5.84821e+06 248 5.73663e+06 0.853383 5630.48 8.59996e+07 14122.2 1.67936e+07 14226.6 1.05021e+07 15704.8 1.46964e+07 1442 1.25993e+07 6843.32 1.88908e+07 6951.2 6.30784e+06 5813.52 1.67936e+07 5717.31 1.67936e+07 4007.06 1.67936e+07 74596 17262.3 56150.7 58512 61481.1 45570.6 4619.2 20893.6 823989 1.17933e+06 8.13451e+06 3.08573e+07 21478.6 18112.5 17519.1 11680.7 3205 403
80369 20240115.9 28127.3 2.51822e+07 6 77678 228 5.6478e+06 245 5.46091e+06 0.785847 5581.66 8.59996e+07 14041.8 1.88908e+07 14189.5 1.05021e+07 15718.9 1.25993e+07 1431.1 1.25993e+07 7259.6 1.67936e+07 7015.5 6.30784e+06 5819.81 1.67936e+07 5730.37 1.67936e+07 3986.19 1.67936e+07 74738.4 17146.4 55979.2 57713.4 61785.9 45423.4 4644.3 20685.7 832130 1.17982e+06 8.14071e+06 3.07609e+07 22112.6 20644.4 17590 11860.7 3537 403

add_contains_globally_committed

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem pi_basic_mt_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states ls_js_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ tlc_sim_traces tlc_sim_levelmean
80363 20240115.6 27897.2 2.51822e+07 0.774322 5653.12 8.59996e+07 99381.4 14080.6 1.88908e+07 14165.2 1.05021e+07 15687.3 1.46964e+07 16764.4 52996.7 57924.7 61464.5 1440.5 1.25993e+07 4609.9 21105.4 7268.57 1.67936e+07 22269.2 7024.9 6.30784e+06 6 77678 237 5.84821e+06 248 5.73663e+06 17386.8 5776.29 1.67936e+07 17449.3 11659.9 5746.96 1.67936e+07 3985.54 1.67936e+07 44581 837311 1.17555e+06 8.17428e+06 3.07535e+07 3241 403
80374 20240115.10 27955.2 2.51822e+07 0.81308 5551.46 8.59996e+07 97818.3 14030.9 1.88908e+07 14182.6 1.05021e+07 15588.7 1.25993e+07 17287.2 55957.2 58168.6 62746.9 1430.1 1.25993e+07 4637.7 20720.3 6794.15 1.67936e+07 22275.2 6925 6.30784e+06 7 77678 224 5.6478e+06 246 5.46091e+06 20659.9 5799.97 1.67936e+07 17519.9 11738.3 5478.5 1.67936e+07 3998.63 1.67936e+07 41709.6 831418 1.18497e+06 8.14437e+06 3.05271e+07 3600 403

images

@eddyashton eddyashton enabled auto-merge (squash) January 15, 2024 16:00
@eddyashton eddyashton merged commit 38b0548 into microsoft:main Jan 15, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add contains_globally_committed on KV Set
2 participants