Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RSASSA-PKCS1-v1_5 with RSA-PSS in crypto API #6415

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Replace RSASSA-PKCS1-v1_5 with RSA-PSS in crypto API #6415

merged 3 commits into from
Aug 5, 2024

Conversation

maxtropets
Copy link
Collaborator

@maxtropets maxtropets commented Jul 31, 2024 •
edited
Loading

Closes #6405

@maxtropets maxtropets requested a review from a team July 31, 2024 19:30
@maxtropets maxtropets self-assigned this Jul 31, 2024
@maxtropets maxtropets marked this pull request as draft August 2, 2024 08:54
@maxtropets maxtropets force-pushed the f/pksc-to-pss branch 4 times, most recently from 5e87d24 to 984e31d Compare August 4, 2024 20:34
@maxtropets maxtropets marked this pull request as ready for review August 4, 2024 21:01
@maxtropets
Copy link
Collaborator Author

Is now back from "Draft". Can be reviewed.

@maxtropets maxtropets requested a review from achamayou August 4, 2024 21:01
@maxtropets maxtropets changed the title Replace PKSC1-v1_5 with PSS Replace RSASSA-PKCS1-v1_5 with RSA-PSS Aug 4, 2024
@maxtropets maxtropets changed the title Replace RSASSA-PKCS1-v1_5 with RSA-PSS Replace RSASSA-PKCS1-v1_5 with RSA-PSS in crypto API Aug 4, 2024
@maxtropets maxtropets added 5.x-todo PRs which should be backported to 5.x 5.x-backport Highlights PRs targeting the 5.x branch auto-backport Automatically backport this PR to LTS branch labels Aug 4, 2024
achamayou
achamayou reviewed Aug 5, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
maxtropets and others added 2 commits August 5, 2024 11:36
@maxtropets @achamayou
Update CHANGELOG.md
b51dd29 
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
@maxtropets
Test update
de24418
@maxtropets maxtropets enabled auto-merge August 5, 2024 11:04
@maxtropets maxtropets disabled auto-merge August 5, 2024 11:29
@maxtropets maxtropets enabled auto-merge August 5, 2024 11:30
@maxtropets maxtropets added this pull request to the merge queue Aug 5, 2024
Merged via the queue into microsoft:main with commit 33cb6d4 Aug 5, 2024
7 checks passed
@maxtropets maxtropets deleted the f/pksc-to-pss branch August 5, 2024 13:15
ghost pushed a commit that referenced this pull request Aug 5, 2024
@maxtropets
Replace RSASSA-PKCS1-v1_5 with RSA-PSS in crypto API (#6415)
29ed454 
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
(cherry picked from commit 33cb6d4)
@ghost ghost mentioned this pull request Aug 5, 2024
Merged
@ghost ghost added the backported This PR was successfully backported to LTS branch label Aug 5, 2024
maxtropets added a commit that referenced this pull request Aug 5, 2024
@maxtropets
[release/5.x] Cherry pick: Replace RSASSA-PKCS1-v1_5 with RSA-PSS in …
9217756 
…crypto API (#6415) (#6425)

Co-authored-by: Max <maxtropets@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achamayou achamayou achamayou approved these changes

Assignees

@maxtropets maxtropets

Labels
5.x-backport Highlights PRs targeting the 5.x branch 5.x-todo PRs which should be backported to 5.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crypto APIs should replace PKCS1v15 with PSS.
2 participants
@maxtropets @achamayou