Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COSE signatures over merkle root in the ledger #6453

Merged
merged 36 commits into from
Sep 11, 2024

Conversation

maxtropets
Copy link
Collaborator

@maxtropets maxtropets commented Aug 27, 2024

Closes #6449

src/kv/deserialise.h Outdated Show resolved Hide resolved
src/node/history.h Outdated Show resolved Hide resolved
src/node/history.h Outdated Show resolved Hide resolved
src/node/history.h Outdated Show resolved Hide resolved
src/node/history.h Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@achamayou
Copy link
Member

@maxtropets ASAN reports a stack use after scope exit in cose_params_string_string, which needs fixing (the simplest is probably to pass the string views as const refs). Please also conduct a run of the performance tests and compare the results with the latest run on main, to confirm the performance impact of this change.

python/src/ccf/ledger.py Outdated Show resolved Hide resolved
@maxtropets
Copy link
Collaborator Author

Local perf run on the feature branch

    "Commit Latency (sig_ms_interval=1ms)": {
        "latency": {
            "value": 3.570866584777832,
            "high_value": 5.024909973144531,
            "low_value": 1.9223690032958984
        }
    },
    "Commit Latency (sig_ms_interval=16ms)": {
        "latency": {
            "value": 5.190229415893555,
            "high_value": 17.133235931396484,
            "low_value": 1.9614696502685547
        }
    },
    "Commit Latency (sig_ms_interval=256ms)": {
        "latency": {
            "value": 208.73398780822754,
            "high_value": 214.36476707458496,
            "low_value": 136.8558406829834
        }
    },
    "Logging": {
        "throughput": {
            "value": 8089.7,
            "high_value": null,
            "low_value": null
        },
        "memory": {
            "value": 96899072,
            "high_value": 96899072,
            "low_value": null
        }
    },
    "Basic": {
        "memory": {
            "value": 114323456,
            "high_value": 114323456,
            "low_value": null
        },
        "throughput": {
            "value": 9423.1,
            "high_value": null,
            "low_value": null
        }
    },
    "Basic JS": {
        "memory": {
            "value": 114425856,
            "high_value": 114425856,
            "low_value": null
        },
        "throughput": {
            "value": 3572.8,
            "high_value": null,
            "low_value": null
        }
    },
    "Logging JWT": {
        "throughput": {
            "value": 4607.0,
            "high_value": null,
            "low_value": null
        },
        "memory": {
            "value": 96792576,
            "high_value": 96792576,
            "low_value": null
        }
    },
    "Historical Queries": {
        "throughput": {
            "value": 105420.24683629272,
            "high_value": null,
            "low_value": null
        }
    },
    "Basic Multi-Threaded": {
        "memory": {
            "value": 114167808,
            "high_value": 114167808,
            "low_value": null
        },
        "throughput": {
            "value": 9413.1,
            "high_value": null,
            "low_value": null
        }
    }
}

Local perf run on main

{
    "Commit Latency (sig_ms_interval=1ms)": {
        "latency": {
            "value": 2.969062328338623,
            "high_value": 4.170417785644531,
            "low_value": 0.9822845458984375
        }
    },
    "Commit Latency (sig_ms_interval=16ms)": {
        "latency": {
            "value": 4.699850082397461,
            "high_value": 10.979652404785156,
            "low_value": 3.6275386810302734
        }
    },
    "Commit Latency (sig_ms_interval=256ms)": {
        "latency": {
            "value": 207.72992372512817,
            "high_value": 215.41619300842285,
            "low_value": 135.17498970031738
        }
    },
    "Logging": {
        "throughput": {
            "value": 8193.0,
            "high_value": null,
            "low_value": null
        },
        "memory": {
            "value": 96776192,
            "high_value": 96776192,
            "low_value": null
        }
    },
    "Basic": {
        "memory": {
            "value": 114327552,
            "high_value": 114327552,
            "low_value": null
        },
        "throughput": {
            "value": 9187.0,
            "high_value": null,
            "low_value": null
        }
    },
    "Basic JS": {
        "memory": {
            "value": 114053120,
            "high_value": 114053120,
            "low_value": null
        },
        "throughput": {
            "value": 3641.7,
            "high_value": null,
            "low_value": null
        }
    },
    "Logging JWT": {
        "throughput": {
            "value": 4575.6,
            "high_value": null,
            "low_value": null
        },
        "memory": {
            "value": 96587776,
            "high_value": 96587776,
            "low_value": null
        }
    },
    "Historical Queries": {
        "throughput": {
            "value": 104487.27676031936,
            "high_value": null,
            "low_value": null
        }
    },
    "Basic Multi-Threaded": {
        "memory": {
            "value": 114053120,
            "high_value": 114053120,
            "low_value": null
        },
        "throughput": {
            "value": 9317.7,
            "high_value": null,
            "low_value": null
        }
    }
}

@achamayou achamayou enabled auto-merge September 11, 2024 17:18
@achamayou achamayou added this pull request to the merge queue Sep 11, 2024
Merged via the queue into microsoft:main with commit b08724a Sep 11, 2024
6 checks passed
@achamayou achamayou deleted the f/cose-sign-merkle-root branch September 11, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COSE signatures and verification in CCF
2 participants