Add API to allow setting unprotected headers #6586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
changed the title
maxtropets
reviewed
Oct 24, 2024
maxtropets
reviewed
Oct 24, 2024
maxtropets
reviewed
Oct 24, 2024
maxtropets
reviewed
Oct 24, 2024
maxtropets
reviewed
Oct 24, 2024
Co-authored-by: Max <maxtropets@gmail.com>
maxtropets
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ccf::cose::edit::set_unprotected_header()API, to allow injection of proofs in signatures, and of receipts in signed statements.Note that this does not preserve existing unprotected header parameters, because I could not find a way to make edits without fully parsing it to an intermediary representation, and re-emitting it with QCBOR. Aside from being quite a lot of code parsing unauthenticated input, this would almost certainly lossy because of variable length encoding used in CBOR, and would in any case not provide any functionality that cannot be implemented on the client side.