Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim SGX-specific packages from playbooks #6617

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

eddyashton
Copy link
Member

Follow-up to #6447. Changing defaults and updating docs to simplify install for SNP/virtual.

@eddyashton eddyashton requested a review from a team November 7, 2024 14:40
@achamayou
Copy link
Member

@eddyashton one thing to be careful with is clang-format.

We've deliberately hardcoded 11 to keep things stable. Right now we still cut CI images from release/5.x, and that still installs clang-format-11 no matter what.

I don't think we will be able to do that on Azure Linux 3.0 (default there is clang-18), so we will have to work out what the transition looks like.

@eddyashton
Copy link
Member Author

@eddyashton one thing to be careful with is clang-format.

We've deliberately hardcoded 11 to keep things stable. Right now we still cut CI images from release/5.x, and that still installs clang-format-11 no matter what.

I don't think we will be able to do that on Azure Linux 3.0 (default there is clang-18), so we will have to work out what the transition looks like.

We should update to a more recent clang-format at some point. But probably after we're cutting from main again. The current diff when formatting with my clang-format-18 isn't too obscene, 19 files touched, just new opinions on where we split lines/allow whitespace. Could potentially minimise that diff further with a different .clang-format, but none of the new options are obvious culprits.

@achamayou achamayou added this pull request to the merge queue Nov 7, 2024
Merged via the queue into microsoft:main with commit 7ad8fb7 Nov 7, 2024
13 checks passed
@achamayou achamayou deleted the trim_sgx_playbooks branch November 7, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants