Fetch fresh snapshot from peer when joining #6700
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joining without a recent snapshot is slow, as some suffix (potentially the entire history) of the ledger must be transferred over the consensus protocol. Operators can attempt to provide recent snapshots to joining nodes, perhaps through a shared backup mount, but this requires operator intervention and is error-prone.
This PR adds a more automated solution. When joining, a node asks the target node for its latest snapshot (on the host, before entering the local enclave). If the target has a later snapshot than is available locally, it is fetched over HTTPS, and will then be used to initialise the node's state. Assuming snapshots are regularly emitted, this should remove the cases where a joining node is forced to replay the entire ledger history.