Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

adding a Qt's wrapper that allows: #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lemmel
Copy link

@lemmel lemmel commented Feb 16, 2018

  • to access from ChakraCore to Qt's Object
  • set variables from C++
  • get variables from ChakraCore

Furthermore it can be a useful because it offers several examples:

  • access to variables from and to ChakraCore
  • registering attribute's object and be able to get notified when they are changed

- to access from ChakraCore to Qt's Object
- set variables from C++
- get variables from ChakraCore

Furthermore it can be a useful because it offers several examples:
- access to variables from ChakraCore
- registering attribute's object and be able to get notified when they are changed
@msftclas
Copy link

msftclas commented Feb 16, 2018

CLA assistant check
All CLA requirements met.

@liminzhu
Copy link
Member

Thanks for the contribution @lemmel !

@Microsoft/chakra-developers anybody familiar with Qt?

@obastemur
Copy link
Contributor

I actually looked a bit while ago and I really liked the effort here.

Concerns;

  • I'm not sure if we can test this through before taking it
  • The looks and feel of the code is not matching to our code && design guidelines
  • Licensing issues may arise ?

Nonetheless, this is an epic effort and I'm sure it will be beneficial for many people using QT.

@lemmel
Copy link
Author

lemmel commented Mar 4, 2018

It is as you want: I can alter the code, add unit test and so on.
Just ask.

P.S. : I will be AFK 2 weeks, so I will not be able to answer or work on this until later in the month.
P.P.S. : I don't see any licensing problem as I give it to public domain, and Qt's licensing has nothing to do here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants