Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I had the exact same issue as #142 #185

Closed
Ellested opened this issue May 16, 2020 · 11 comments
Closed

I had the exact same issue as #142 #185

Ellested opened this issue May 16, 2020 · 11 comments
Assignees

Comments

@Ellested
Copy link

I've spend more time on getting this thing to build, than my upcoming PR - I'm almost giving up.

Could you possibly include the V8 binaries and .dbg files for ease of use?

I also have problems with loading the .net framework test project. It could not import the project, as it wasn't found to be compatible?
I don't see why, and the error message points me to Microsoft page with nothing on the issue - any ideas?

I'm using VS2019 latest, and all SDK stuff etc. is in place as described in the docs.

@Ellested
Copy link
Author

Got so far now:
image

But it actually works fine:
image

@Ellested Ellested changed the title I have the exact same issue as #142 I had the exact same issue as #142 May 16, 2020
@Ellested
Copy link
Author

image

Back to square one...

@Ellested
Copy link
Author

Cleaning up environment path, fixed the above issue. As the error says, it's too long.

However, it just starts failing later on with the same problems. Seems like the build is using a lot of path concatenations, which end ups in errors if you don't start from a clean installed windows :-)

Maybe it's better to start the build with getting the directories you need, and filter the rest out - then the script can concatenate what is needed and hereby make sure it's working on all machines. Last step could restore the original path variable.

Anyway, it's stupid that we have to deal with limitations on command line length - someone at Microsoft should increase the buffers :-)

@ClearScriptLib
Copy link
Collaborator

Hi @Ellested,

We've seen environment-related issues on some machines recently as well. Unfortunately we haven't found a robust solution.

In some cases we've been able to work around the problems by moving the ClearScript directory to a drive root. We've also found that using setlocal/endlocal to isolate the environment separately for the 32-bit and 64-bit builds helps in some cases. That change will be in the next release.

On the other hand we're not aware of any issues with the Visual Studio project files. If you get your V8 build working, let us know if your Visual Studio issues persist.

You can get ClearScript binaries on nuget.org. We're working on a way to also publish the PDBs, but unfortunately we have no ETA for that.

Good luck!

@Ellested
Copy link
Author

Ellested commented May 16, 2020

image
I'm back to this issue again. I've backed up my env variables (with "Rapid Environment Editor", if anyone needs to do that), and have only a few folders left. I've also substituted drive Y for C:\Users\KE\Source\Git\ClearScript
The only thing left is that I get a warning that python is version 3, what version is known to work?

@ClearScriptLib
Copy link
Collaborator

Hi @Ellested,

We also see the Python v3 warning, but the build succeeds, so that's probably not the problem.

Our only recommendation would be to open a new Visual Studio command prompt, trim your path, and try again with ClearScript at the drive root. That works for us on all the machines we've tested.

If it still fails for you, we'd love to see a full log, if you can capture it.

Good luck!

@Ellested
Copy link
Author

HA - it finally worked :-)
setlocal/endlocal did the trick
Thanks - and it builds on a substituted drive too

Now the test project...

@Ellested
Copy link
Author

Ellested commented May 16, 2020

image

The link is just a standard landing page with some pointers. I'll see if I can find out what it is, but apparently I don't have the required application type.

Well, I think this one is my bad. I cannot even create a new C# .net framework test project, as it can't find this project type.
Test | {3AC096D0-A1C2-E12C-1390-A8335801FDAB}

So repairing at the moment and crossing my fingers...

Everything is working - finally :-)

@Ellested
Copy link
Author

Why are you using C#5.0 - I mean it's pretty old now - from 2012?
Are there any hidden constraints, as I believe all version of .net framework supports 7.3 at least.

@ClearScriptLib
Copy link
Collaborator

Why are you using C#5.0 - I mean it's pretty old now - from 2012?

The project does go back that far. We put in the restriction to retain source compatibility with Visual Studio 2012, and it's just been inertia since then. C# 5 is also still the current Ecma and ISO standard.

ClearScriptLib added a commit that referenced this issue May 29, 2020
…; added JavaScriptExtensions.ToTask (GitHub Issue #182); added DocumentLoader.MaxCacheSize and DocumentCategory.MaxCacheSize; added code to break event connections on engine disposal (GitHub Issue #183); improved ES6 module support, fixing cycle crash (GitHub Issue #181); added DynamicHostObject (GitHub Issue #180); added BigInt / BigInteger support for V8 (GitHub Issue #176); hardened Assembly.Load call in V8Proxy.cs (GitHub Issue #175); improved V8Update environment isolation to fix some V8 build issues (GitHub Issue #185); updated API documentation. Tested with V8 8.3.110.9.
@ClearScriptLib
Copy link
Collaborator

Version 6.0.2 isolates the environment in V8Update during 32-bit and 64-bit V8 builds. Please open a new issue if you encounter additional problems building V8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants