Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NativeMethods.json + NativeMethods.txt from the None build action #850

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Remove NativeMethods.json + NativeMethods.txt from the None build action #850

merged 1 commit into from
Jan 20, 2023

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Jan 19, 2023

Since NativeMethods.json and NativeMethods.txt are added to the AdditionalFiles build action they appear twice in Rider.

Before this pull request:
image

After this pull request:
image

@0xced
Remove NativeMethods.json + NativeMethods.txt from the None build action
83f1f14 
Since NativeMethods.json and NativeMethods.txt are added to the AdditionalFiles build action they appear twice in Rider.
AArnott
AArnott approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@AArnott AArnott merged commit cddc9a5 into microsoft:main Jan 20, 2023
@0xced 0xced deleted the None-Remove-NativeMethods branch January 20, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xced @AArnott