Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for non-remotable COM interfaces #878

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Fix for non-remotable COM interfaces #878

merged 1 commit into from
Mar 9, 2023

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Mar 9, 2023

We now prefer to use in, out and ref modifiers on parameters instead of pointers, even on the original interface method definition. The reason is the CLR and Core CLR cannot marshal pointers across processes, but it can marshal these modifiers without a problem. Some interfaces are used across these boundaries, although CsWin32 doesn't know which. So we just err on generating interfaces that can be used in this way.

This does unfortunately mean that some methods that took pointers and had overloads that took Span<T> no longer will, which means more marshaling and more array allocations. This only impacts the less perf-critical (and default) scenario where marshaling is allowed though, so I don't think it will be a big problem.

Fixes #860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IShellWindows.FindWindowSW definition throws NotSupportedException unless int* is changed to out int
1 participant