Fix for non-remotable COM interfaces #878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now prefer to use
in
,out
andref
modifiers on parameters instead of pointers, even on the original interface method definition. The reason is the CLR and Core CLR cannot marshal pointers across processes, but it can marshal these modifiers without a problem. Some interfaces are used across these boundaries, although CsWin32 doesn't know which. So we just err on generating interfaces that can be used in this way.This does unfortunately mean that some methods that took pointers and had overloads that took
Span<T>
no longer will, which means more marshaling and more array allocations. This only impacts the less perf-critical (and default) scenario where marshaling is allowed though, so I don't think it will be a big problem.Fixes #860