Embedded sources: WinRT.Runtime #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
reviewed
Oct 11, 2021
manodasanW
reviewed
Oct 11, 2021
manodasanW
reviewed
Oct 11, 2021
manodasanW
reviewed
Oct 11, 2021
manodasanW
reviewed
Oct 11, 2021
manodasanW
approved these changes
Oct 11, 2021
manodasanW
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds logic to change the WinRT.Runtime sources to work as an embeddable module. This is the first part of adding Embedded support.
There are two changes included here, spread across multiple files.
Changing
!NETSTANDARD2_0toNET(orNETSTANDARD2_0to!NET). This is required for enabling cross-targeting. A netcoreapp3.1 app trying to use embedded sources will be blocked by[!]NETSTANDARD2_0.Adding a option to each public type to be internal if the EMBED constant is defined.
Note that the EMBED constant will never be defined (it is coming in a later PR), so these changes are inert.