Embedded sources: cswinrt #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0shuams
force-pushed
the
jlarkin/embed-2
branch
from
97d2058
to
87b2f56
Compare
manodasanW
reviewed
Oct 11, 2021
manodasanW
reviewed
Oct 11, 2021
src/cswinrt/strings/additions/Windows.Foundation/Windows.Foundation.SR.cs
Outdated
Show resolved
Hide resolved
|
Looks good, assuming the comment regarding RegisterProjectionAssembly is addressed. |
manodasanW
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes changes needed to cswinrt for embedded support.
We now generate internal sources, based on a new argument to cswinrt.exe.
And we update the strings/ sources, reflect the embedded changes needed for WinRT.Runtime.
Note that the EMBED constant will never be defined (it is coming in a later PR), so these changes are inert.