Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'CsWinRTIncludes' check in .targets file #1625

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

Sergio0694
Copy link
Member

Small follow up to #1604. This PR fixes the .targets file to make sure that CsWinRTCcwLookupTableGeneratorEnabled is correctly set to false in cases where CsWinRTInclude is set to some string value, including multilines. This also fixes Win2D.

@Sergio0694 Sergio0694 added performance Related to performance work trimming labels May 22, 2024
@dongle-the-gadget
Copy link
Contributor

There's also CsWinRTParam, so make sure to check that.

@Sergio0694
Copy link
Member Author

That property wasn't being checked before this PR either, so I just kept that behavior as is.

@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/fix-global-vtable-target branch from 967c78a to 72d96e1 Compare June 5, 2024 17:53
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/fix-global-vtable-target branch from 72d96e1 to c224578 Compare June 5, 2024 21:32
@Sergio0694 Sergio0694 merged commit a3dfd89 into staging/AOT Jun 6, 2024
10 checks passed
@Sergio0694 Sergio0694 deleted the user/sergiopedri/fix-global-vtable-target branch June 6, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Related to performance work trimming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants