Adds ignore_index to sequence parallel cross entropy #6882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree [company="Bloomberg Industry Group"] |
|
@microsoft-github-policy-service agree company="Bloomberg Industry Group" |
loadams
reviewed
Dec 18, 2024
loadams
approved these changes
Dec 18, 2024
|
Hello all, after working on the integration more I no longer think this PR is needed. Sorry about that. Closing until further notice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change to add
ignore_indexto 100% integration w/ Hugging Face:huggingface/transformers#35301
I also considered adding
reductionhere, and just returningloss.mean()/sum()accordingly. I can add that as well if you all thinks that makes sense.