Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error out when cpu accelerator doesn't have torch (as default for whl building) #6886

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

loadams
Copy link
Contributor

@loadams loadams commented Dec 18, 2024

This fixes a bug introduced in #6845, which breaks the no-torch workflow that we require in order to do releases where we do not require torch to be in the environment when building an sdist. This adds the same logic to the cpuaccelerator that the cudaaccelerator had where we don't require torch to be installed to build the whl.

Copy link
Contributor

@sfc-gh-mwyatt sfc-gh-mwyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loadams loadams merged commit 4cd1d97 into master Dec 18, 2024
11 of 12 checks passed
@loadams loadams deleted the loadams/fix-no-torch-cpu-import branch December 18, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants