Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 3d operators #507

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

dmenig
Copy link
Contributor

@dmenig dmenig commented Sep 17, 2023

The tests pass !

test_results.txt

@fdwr fdwr requested a review from jstoecker September 18, 2023 01:35
@dmenig dmenig force-pushed the 3d_operators_3 branch 7 times, most recently from b57aba1 to 42bfcc9 Compare September 21, 2023 17:11
@dmenig dmenig force-pushed the 3d_operators_3 branch 3 times, most recently from 93c77c1 to d4b5d65 Compare September 22, 2023 10:53
Copy link
Contributor

@jstoecker jstoecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@jstoecker jstoecker merged commit 4069e9f into microsoft:master Sep 22, 2023
1 check passed
@dmenig dmenig deleted the 3d_operators_3 branch September 24, 2023 17:39
@ratkiller98
Copy link

ratkiller98 commented Jul 19, 2024

@dmenig Would you mind verifying if it works on pretrained 3D models from timm_3d or torchvision library on pytorch. As I had no luck using my vega 56 for the task because of the same issue of

: RuntimeError: input must be 4-dimensional

happening with my timm_3d models with torch-directml but not with CPU.

Using Pytorch Version: 2.3.1, and Torch-Directml Version: 0.2.3.dev240715

@dmenig
Copy link
Contributor Author

dmenig commented Jul 19, 2024

I really have no idea how to do that :/

@dmenig
Copy link
Contributor Author

dmenig commented Jul 19, 2024

Oh you have managed to use it, great ! I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants