Add UpdateSubresource and MemcpySubresource overloads taking D3D12_SUBRESOURCE_INFO* #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BRESOURCE_INFO* Adds overloads for all 3 `UpdateSubresources` and `MemcpySubresource` which takes `D3D12_SUBRESOURCE_INFO` (which stores an offset rather than an absolute pointer) and a `const void*` rather than `D3D12_SUBRESOURCE_DATA`, which is useful in several scenarios working with D3D from .NET (where interior data pointers cannot be trivially passed around or stored on the heap),
jenatali
approved these changes
Jun 22, 2020
|
@john-h-k thank you! I resolved a conflict, if you're happy with the change I'll merge it and update the rest of the samples to use this new version of d3dx12.h. |
|
Thanks! Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds overloads for all 3
UpdateSubresourcesandMemcpySubresourcewhich takesD3D12_SUBRESOURCE_INFO(which stores an offset rather than an absolute pointer) and aconst void*rather thanD3D12_SUBRESOURCE_DATA, which is useful in several scenarios working with D3D from .NET (where interior data pointers cannot be trivially passed around or stored on the heap, as well general scenarios where offsets are stored rather than the absolute subresource pointers)cc @jenatali as i mentioned in discord 😄