Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPIR-V] Unnecessary extension emitted: SPV_NV_shader_subgroup_partitioned #6672

Closed
llvm-beanz opened this issue Jun 5, 2024 · 2 comments · Fixed by #6687
Closed

[SPIR-V] Unnecessary extension emitted: SPV_NV_shader_subgroup_partitioned #6672

llvm-beanz opened this issue Jun 5, 2024 · 2 comments · Fixed by #6687
Labels
bug Bug, regression, crash spirv Work related to SPIR-V

Comments

@llvm-beanz
Copy link
Collaborator

Description
DXC 1.8.2504 emits unnecessary required extension SPV_NV_shader_subgroup_partitioned.

This regression is introduced with: #6546

Steps to Reproduce
Comparison of 1.8.2403.2 and 1.8.2405

Environment

  • DXC version: DXC 1.8.2504
  • Host Operating System: All
@llvm-beanz llvm-beanz added bug Bug, regression, crash spirv Work related to SPIR-V needs-triage Awaiting triage labels Jun 5, 2024
@devshgraphicsprogramming
Copy link

I think all that's needed is to add this extension to the capability & extension stripping pass in the SPIR-V Tools repository

@Keenuts
Copy link
Collaborator

Keenuts commented Jun 6, 2024

Hi,

That's right, we haven't added support for this extension in the capability trimming pass. Looking as the extension doc, it seems we will be able to solve the issue that way.

@Keenuts Keenuts removed the needs-triage Awaiting triage label Jun 6, 2024
@Keenuts Keenuts moved this to For Google in HLSL Triage Jun 6, 2024
@Keenuts Keenuts moved this from For Google to Triaged in HLSL Triage Jun 6, 2024
@turanszkij turanszkij mentioned this issue Jun 9, 2024
Open
5 tasks
This was referenced Jun 11, 2024
Merged
Merged
Keenuts added a commit that referenced this issue Jun 12, 2024
@Keenuts
[SPIR-V] Fix GroupNonUniform capabilities+ext (#6687)
80f6e46 
[SPIR-V] Fix GroupNonUniform capabilities+ext

Fixes emission of GroupNonUniform capabilities and related extensions,
in particular SPV_NV_shader_subgroup_partitioned.

Since this PR bumps SPIR-V headers + tools, some test changes are
required due to opcode changes. Those are in a separate commit, but same
PR.

Fixes #6672

---------

Signed-off-by: Nathan Gauër <brioche@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug, regression, crash spirv Work related to SPIR-V
Projects
HLSL Triage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SPIR-V] Fix GroupNonUniform capabilities+ext Keenuts/DirectXShaderCompiler
3 participants
@Keenuts @devshgraphicsprogramming @llvm-beanz