Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] WinAdapter: Export helper functions to interact with shimmed types #3265

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[RFC] WinAdapter: Export helper functions to interact with shimmed types #3265

wants to merge 3 commits into from

Commits on May 22, 2021

  1. WinAdapter: Export helper functions that operate on support types 

    The implementation of these support types completely depends on DXC.  As
such applications using libdxcompiler.so have to guess and/or look at
the source code to understand how they are implemented (eg prefix size
for BSTR), and assume this is not going to change.  Applications using
these newly exported symbols can do it "the right way" as if they are on
Windows.
    @MarijnS95
    MarijnS95 committed May 22, 2021
    Configuration menu
    Copy the full SHA
    15a8fc0 View commit details
    Browse the repository at this point in the history

  2. WinAdapter: Export SysStringLen helper for BSTR

    @MarijnS95
    MarijnS95 committed May 22, 2021
    Configuration menu
    Copy the full SHA
    9200fff View commit details
    Browse the repository at this point in the history

  3. WinAdapter: Export symbols for CoTaskMem{Alloc,Free} 

    Some functions return lists allocated with CoTaskMemAlloc.  Applications
using libdxcompiler.so currently have to look into the code to
understand that these should be deallocated with free() instead of
delete[].  Export the CoTaskMemFree function so that there is no
guesswork involved anymore: the application can now call this function
and always free it in the right way.
    @MarijnS95
    MarijnS95 committed May 22, 2021
    Configuration menu
    Copy the full SHA
    3c42468 View commit details
    Browse the repository at this point in the history