Add support for custom allocators #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Build DirectXShaderCompiler 1.0.388 failed (commit 0701c580f4 by @marcelolr) |
tex3d
reviewed
Jun 28, 2017
lib/Analysis/ScalarEvolution.cpp
Outdated
| cl::desc("Maximum number of iterations SCEV will " | ||
| "symbolically execute a constant " | ||
| "derived loop"), | ||
| cl::init(100)); |
There was a problem hiding this comment.
Unintended indentation changes?
lib/Analysis/TargetLibraryInfo.cpp
Outdated
| "No vector functions library"), | ||
| clEnumValN(TargetLibraryInfoImpl::Accelerate, "Accelerate", | ||
| "Accelerate framework"), | ||
| clEnumValEnd)); |
lib/Analysis/ValueTracking.cpp
Outdated
| /// Enable an experimental feature to leverage information about dominating | ||
| /// conditions to compute known bits. The individual options below control how | ||
| /// hard we search. The defaults are choosen to be fairly aggressive. If you | ||
| /// run into compile time problems when testing, scale them back and report | ||
| /// your findings. | ||
| static cl::opt<bool> EnableDomConditions("value-tracking-dom-conditions", | ||
| cl::Hidden, cl::init(false)); | ||
| cl::Hidden, cl::init(false)); |
There was a problem hiding this comment.
More indent changes and below..
lib/Analysis/regioninfo.cpp
Outdated
| clEnumValN(Region::PrintRN, "rn", | ||
| "print regions in detail with element_iterator"), | ||
| "print regions in detail with element_iterator"), |
lib/Analysis/DependenceAnalysis.cpp
Outdated
| static cl::opt<bool> | ||
| Delinearize("da-delinearize", cl::init(false), cl::Hidden, cl::ZeroOrMore, | ||
| cl::desc("Try to delinearize array references.")); | ||
| cl::desc("Try to delinearize array references.")); |
| unsigned Column) { | ||
| const std::string &Filename, | ||
| unsigned Line, | ||
| unsigned Column) { |
| llvm::outs())); | ||
| Loc.FileName, Loc.Line, Loc.Column, | ||
| getFrontendOpts().CodeCompleteOpts, | ||
| llvm::outs())); |
| Loc.Line, Loc.Column)) { | ||
| } | ||
| else if (EnableCodeCompletion(getPreprocessor(), Loc.FileName, | ||
| Loc.Line, Loc.Column)) { |
| unsigned Line, | ||
| unsigned Column, | ||
| const CodeCompleteOptions &Opts, | ||
| raw_ostream &OS) { |
There was a problem hiding this comment.
indent-only changes here and above/below
| @@ -147,7 +148,13 @@ bool VersionSupportInfo::SkipDxil_1_1_Test() { | |||
| } | |||
| return false; | |||
| } | |||
|
|
|||
| bool VersionSupportInfo::SkipOutOfMemoryTest() { | |||
| if (m_CompilerPreservesBBNames) { // same detection logic at the moment | |||
There was a problem hiding this comment.
Should probably just rename this member to m_CompilerIsDebugBuild or something, since that's what it really tracks.
|
❌ Build DirectXShaderCompiler 1.0.414 failed (commit 6662367b52 by @marcelolr) |
|
❌ Build DirectXShaderCompiler 1.0.415 failed (commit 035d1edc09 by @marcelolr) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big change that cleans up various aspects of memory management and adds support for memory allocators to be passed into the library.
There is a new entry point into dxcompiler, DxcCreateInstance2, which allows for the caller to provide an IMalloc implementation that will be used for all memory operations involving calls into that object. In support of this, the following changes are made.
There is likely more work to be done on cleaning up in exception paths properly in the presence of bad_alloc exceptions, but this is a step in the right direction.
This capability allows the compiler and its component libraries to be used in scenarios where memory allocation policy is directed by the application, for example by limiting the maximum available memory, allocating with some particular book-keeping strategy, or using a specific area of memory.