Added unused output target warning and moved usage mask fill location #3947
Conversation
Added unused output target warning and test
There was a problem hiding this comment.
No functional suggestions. just some things that might improve readability.
As to the test failure, it's falling prey to the devops issue with macos-10 and python3. It seems to be pulling the yaml file from your local branch instead of the main branch. If you rebase your local branch and push the change here, I think the test will pass
| : SV_Target0, out float4 outRT1 | ||
| : SV_Target1, out float4 outRT2 | ||
| : SV_Target2, out float4 outRT3 | ||
| : SV_Target3) { |
There was a problem hiding this comment.
I suspect this fell victim to some autoformatting that makes it confusing to read. I think it's worth changing it so that the SV_Target*s are on the same line as the parameters they apply to.
lib/HLSL/DxilPreparePasses.cpp
Outdated
| DxilSignature &sig = DM.GetOutputSignature(); | ||
| for (auto &Elt : sig.GetElements()) { | ||
| if (Elt->GetKind() == Semantic::Kind::Target) { | ||
| if (Elt->GetUsageMask() != Elt->GetColsAsMask()) { |
There was a problem hiding this comment.
you might consider combining these conditionals with && to reduce the indenting, which for me hinders readability
Added a warning for output targets that are not fully written in a shader by checking the signature element usage mask.
Also moved the location where the signature element usage masks are filled to more accurately reflect which channels have been assigned for each element. The signature element usage masks were previously completely filled for a target if at least one of the channels were assigned.