add barycentrics ordering check onto existing barycentrics test #4635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pow2clk
reviewed
Sep 14, 2022
| <RootSignature>RootFlags(ALLOW_INPUT_ASSEMBLER_INPUT_LAYOUT)</RootSignature> | ||
| <Resource Name="VBuffer" Dimension="BUFFER" Width="1024" Flags="ALLOW_UNORDERED_ACCESS" InitialResourceState="COPY_DEST" Init="ByName" ReadBack="true"> | ||
| </Resource> | ||
| <Resource Name="RTarget" Dimension="TEXTURE2D" Width="64" Height="64" Format="R32G32B32A32_FLOAT" Flags="ALLOW_RENDER_TARGET" InitialResourceState="COPY_DEST" ReadBack="true" /> |
There was a problem hiding this comment.
If we can make the render targets the same size, you can use different entry point targets to make one ubershader and prevent duplicating the shader code above with slight modifications.
pow2clk
reviewed
Nov 2, 2022
|
❌ Build DirectXShaderCompiler 1.0.2462 failed (commit 7e80ac610a by @bob80905) |
tex3d
reviewed
Dec 14, 2022
| 2 == GetAttributeAtVertex(input.svid, 2)) | ||
| { | ||
| // special value of all 1's in a float4 will be returned if the ordering is maintained for this pixel. | ||
| return float4(1.0, 1.0, 1.0, 1.0); |
There was a problem hiding this comment.
An alternative way to do this (without the if) is:
return float4(float3(GetAttributeAtVertex(input.svid, 0),
GetAttributeAtVertex(input.svid, 1),
GetAttributeAtVertex(input.svid, 2)) * 0.5, 1.0)
```
then change the expected result to (0, 0.5, 1.0, 1.0) which makes out-of-order failure case reveal the ordering used in the result.
pow2clk
reviewed
Dec 15, 2022
pow2clk
approved these changes
Dec 15, 2022
bob80905
changed the title
hekota
pushed a commit
to hekota/DirectXShaderCompiler
that referenced
this pull request
Dec 16, 2022
…osoft#4635) * add barycentrics ordering check onto existing barycentrics test, with extra shader (cherry picked from commit ee0994e)
hekota
added a commit
that referenced
this pull request
Dec 16, 2022
Cherry-pick of PIX and HLK changes for the 2212 release Changes for PIX: 20bb3d0 PIX: Modify root sigs in place (plus fix root sig memory leak) (PIX: Modify root sigs in place (plus fix root sig memory leak) #4876) 2c3d965 dxcopt: Support full container and restore extra data to module (dxcopt: Support full container and restore extra data to module #4845) 21cf36a Fix hitgroup metadata argument order HLK Test Updates: ee0994e add barycentrics ordering check onto existing barycentrics test (add barycentrics ordering check onto existing barycentrics test #4635) 6acd11b ConvertFloat32ToFloat16: Use DirectXMath conversion functions (ConvertFloat32ToFloat16: Use DirectXMath conversion functions #4855) e7aac8e Include TestConfig.h only if DEFAULT_TEST_DIR is not defined (Include TestConfig.h only if DEFAULT_TEST_DIR is not already defined #4884) 5decc4a Do not include TestConfig.h for all HLK build (Do not include TestConfig.h for all HLK build #4887)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing barycentrics test failed to account for an extra part of the specification.
No matter in which order the vertices are passed to the pixel shader, GetAttributeAtVertex on the svid of each vertex should equal the numbered vertex that's given to the GetAttributeAtVertex function.
So, this test was added inside of the barycentrics test, with an extra shader to accomplish the test.
If this spec is met, then the associated pixel will write a float4 of all 1.0's to the render target view. These pixels are specifically tested to see if the ordering constraint is met.