[SPIRV] Use copy-in/copy-out for non-declaration #7127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DXC tries to avoid the copy-in-copy-out for some parameters when it thinks it is possible. However, the SPIR-V spec says that if a parameter is a pointer, it must point to a memory object declarion or a pointer to an element in a sampler or image array. This PR enforces this. If the pointer for the parameter is not an OpVariable (a memory object declaration), then we do not elide the copy-in copy-out. Fixes microsoft#7095 Fixes microsoft#5191
cassiebeckley
approved these changes
Feb 6, 2025
|
How badly does this affect our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DXC tries to avoid the copy-in-copy-out for some parameters when it
thinks it is possible. However, the SPIR-V spec says that if a parameter
is a pointer, it must point to a memory object declarion or a pointer to
an element in a sampler or image array.
This PR enforces this. If the pointer for the parameter is not an
OpVariable (a memory object declaration), then we do not elide the
copy-in copy-out.
Fixes #7095
Fixes #5191
Fixes #3645