Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python API and Test Suite #300

Merged
merged 19 commits into from
Apr 5, 2023
Merged

Python API and Test Suite #300

merged 19 commits into from
Apr 5, 2023

Commits on Mar 30, 2023

  1. The first step in the python-api-enhancements branch. We need to fix … 

    …a problem with the Parameters class with a double free or segfault on deletion.

This commit has gone a bit wonky in process, so we want to be extra careful it was resolved appropriately during PR.
    @daxpryce
    daxpryce committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    472020e View commit details
    Browse the repository at this point in the history

  2. Removing the parameters class in favor of the IndexRead and IndexWrit… 

    …e parameters classes.
    @daxpryce
    daxpryce committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    ac2499c View commit details
    Browse the repository at this point in the history

  3. clang-format changes

    @daxpryce
    daxpryce committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    b1c7730 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Merge branch 'main' into daxpryce/python-api-enhancements

    @daxpryce
    daxpryce committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    e843f19 View commit details
    Browse the repository at this point in the history

  2. This commit includes the API changes and python packaging changes for… 

    … linux. It's almost ready for PR, but definitely ready for push.
    @daxpryce
    daxpryce committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    a6bda82 View commit details
    Browse the repository at this point in the history

  3. Running clang-format over the bindings file

    @daxpryce
    daxpryce committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    5015e81 View commit details
    Browse the repository at this point in the history

  4. Validation of value ranges was incorrect.

    @daxpryce
    daxpryce committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    a5e76eb View commit details
    Browse the repository at this point in the history

  5. Suppressing the CIBuildWheel step on windows

    @daxpryce
    daxpryce committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    5de77c2 View commit details
    Browse the repository at this point in the history

  6. Trying to install a specific python version and the specific wheel th… 

    …at cibuildwheel made for us prior to running the tests
    @daxpryce
    daxpryce committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    77ce4db View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Making sure the python unit tests run during push as well as PR

    @daxpryce
    daxpryce committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    283e1a6 View commit details
    Browse the repository at this point in the history

  2. Wildcard path seems to be invalid so I'm trying the one I know that w… 

    …orks locally. It will still be wrong in the pr-test but that's canceling itself for no reason well before it gets to mine and I just want to make sure it's working on push at least
    @daxpryce
    daxpryce committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c1ff240 View commit details
    Browse the repository at this point in the history

  3. Forgot the scikit-learn dep

    @daxpryce
    daxpryce committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    3b07428 View commit details
    Browse the repository at this point in the history

  4. Forgot the scikit-learn dep

    @daxpryce
    daxpryce committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    d9fb349 View commit details
    Browse the repository at this point in the history

  5. added in-mem index class to python bindings (#301) 

    * added in-mem dynamic index class to python bindings

* added static in memory index python binding

* clang format
    @harsha-simhadri
    harsha-simhadri authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    949167c View commit details
    Browse the repository at this point in the history

  6. Advancing our version number to 0.5.0

    @daxpryce
    daxpryce committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    f1842d2 View commit details
    Browse the repository at this point in the history

  7. Some more updates as per harsha's comments on PR #300. The diskann_bi… 

    …ndings.cpp still need some more tlc and the wrapper needs to make use of it, and we also want to include some examples, but this is a good place to bring into main and then do further enhancements
    @daxpryce
    daxpryce committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    e624ace View commit details
    Browse the repository at this point in the history

  8. Addressing harsha's comment regarding _pvmamanaIndex changing to just… 

    … _index
    @daxpryce
    daxpryce committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    2b6e1e5 View commit details
    Browse the repository at this point in the history

  9. clang format

    @daxpryce
    daxpryce committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    16019c7 View commit details
    Browse the repository at this point in the history

  10. Fixing a couple small typos

    @daxpryce
    daxpryce committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    d38c9eb View commit details
    Browse the repository at this point in the history