[Release] Increase to version 1.1.2 (and Fix for #31) #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[BUG] _checkPrototype function loops indefinitely when calling Invoke-WebRequest cmdlet against a docs.microsoft.com webpage #31
MSNev
commented
Apr 16, 2021
| @@ -135,7 +135,7 @@ function _getObjProto(target:any) { | |||
| } | |||
|
|
|||
| // target[Constructor] May break if the constructor has been changed or removed | |||
| let newProto = target[str__Proto] || target[Prototype] || target[Constructor]; | |||
| let newProto = target[str__Proto] || target[Prototype] || (target[Constructor] ? target[Constructor][Prototype] : null); | |||
There was a problem hiding this comment.
This is the root location of the issue, when IE is running in IE7 mode target.__proto__ (target[str__Proto]) and target.prototype (target[Prototype]) don't exist on the root prototype and the final fallback of the target.constructor is also incomplete.
This issue ONLY affects IE7... Which is not strictly supported, but this was causing an endless loop in _checkPrototype()
MSNev
commented
Apr 16, 2021
| // This method doesn't existing in older browsers (e.g. IE8) | ||
| if (_objGetPrototypeOf) { | ||
| // As this is primarily a coding time check, don't bother checking if running in IE8 or lower | ||
| let visited:any[] = []; |
There was a problem hiding this comment.
Copied the visited workaround (to avoid the endless loop) from the previous fix from March -- which fixed IE8 support
hectorhdzg
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG] _checkPrototype function loops indefinitely when calling Invoke-WebRequest cmdlet against a docs.microsoft.com webpage #31