[IE8] Fix in 1.1.5 only handles 2 levels of dynamically nested classes #50 #51
Conversation
| if (!target[DynProtoPolyProto]) { | ||
| target[DynProtoPolyProto] = newProto; | ||
| } | ||
| let curProto = target[str__Proto] || target[Prototype] || (target[Constructor] ? target[Constructor][Prototype] : null); |
There was a problem hiding this comment.
Note: This code is only reached for runtimes that don't support getPrototypeOf() https://caniuse.com/?search=getPrototypeOf
| // As this prototype doesn't have this property then this is from an inherited class so newProto is the base to return so save it | ||
| // so we can look it up value (which for a multiple hierarchy dynamicProto will be the base class) | ||
| newProto = target[DynProtoBaseProto] = target[DynProtoCurrent] || target[DynProtoBaseProto]; | ||
| target[DynProtoCurrent] = curProto; |
There was a problem hiding this comment.
For IE, we need to track both the current and previous as once we are looking at a sub-class we can't see the parent.
| if (!_hasOwnProperty(target, DynProtoBaseProto)) { | ||
| // As this prototype doesn't have this property then this is from an inherited class so newProto is the base to return so save it | ||
| // so we can look it up value (which for a multiple hierarchy dynamicProto will be the base class) | ||
| newProto = target[DynProtoBaseProto] = target[DynProtoCurrent] || target[DynProtoBaseProto]; |
There was a problem hiding this comment.
This might look strange, but the trick here is that because the previous prototype has a DynProtoCurrent value of that prototype is what we get (before we assign the current one on the next line).
| @@ -161,9 +173,8 @@ function _getObjProto(target:any) { | |||
| */ | |||
| function _forEachProp(target: any, func: (name: string) => void) { | |||
| let props: string[] = []; | |||
| let getOwnProps = Obj["getOwnPropertyNames"]; | |||
There was a problem hiding this comment.
Just moved this so it's only done once instead of every call as it won't change.
| @@ -133,25 +143,28 @@ function _isObjectArrayOrFunctionPrototype(target:any) | |||
| * @ignore | |||
| */ | |||
| function _getObjProto(target:any) { | |||
| let newProto; | |||
|
|
|||
| if (target) { | |||
| // This method doesn't existing in older browsers (e.g. IE8) | |||
|
Manual only as this path is only executed on older browsers, so I created a couple of manual "HelloWorld.html" files for ApplicationInsights and 1P version, which I can then enable IE mode and force it into IE8 mode. Which requires manually debugging and stepping into this area of the code. Which isn't fun because of the amount of debugging information available with IE or Edge in IE Mode is well, bad. |
No description provided.