Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variants for feature flags #250
Add variants for feature flags #250
Changes from 80 commits
d28bf88
c1451d3
d087e7b
87aa5a8
55e2264
1918bf9
3e3ab2e
703f89a
e225d22
c233ec6
3a8bac1
fa2133c
86ff346
c445e46
cd09ec2
0a4dcfb
82055ad
34375e6
1f6318b
1f76adc
ee98bbe
42a7cbc
3df6f32
cbc322e
7e801d9
ee3fdb0
76ad51f
b7a97a7
370228e
a259e23
2850421
96b636d
43e1b13
5f6328e
fbc20fe
46a263e
baac628
6672af6
4d6064b
6012ec3
d2543ea
8d59200
77fc24b
a286d43
9bbd115
3ea099b
8306eb4
8765c93
a3466c7
eb80694
0b8f9e9
1da4d2a
dff6044
adbf40f
875a422
05b31b1
c50c96e
95e6459
744b966
02f6e55
efbab17
e4cddae
e8a640b
dc49a2f
d184882
49aa2fb
a0a787a
6ef1fce
2067d27
3fa5f53
c745f59
de67697
29bce04
9c7765d
1fb1c67
6dfb3ec
827c0ae
656ec67
bed8093
03e8e47
e1cb0d2
23ff1ef
2340b8c
3827494
755687e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come
{0}
isn't in single quotes ? And shouldn't it be "Invalid settting '{0}' with value..."There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just based the format string off of the old error message, but since we're using a variable now I understand adding the single quotes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The knowledge that configurationSection.Key is feature name is a bit of odd encapsulation. I'd suggest updating the method signature.