build(client): Use new node16 tsconfigs in azure, client, and DDS pro…

…jects (#18152)

This PR is the first in several that will update the CommonJS builds
within the repo to use `module: node16`, which implies
`moduleResolution: node16`.

There are new configs in the build-common package, and these configs are
used as follows:

```json
"extends": [
	"../../../../../common/build/build-common/tsconfig.base.json",
	"../../../../../common/build/build-common/tsconfig.cjs.json",
],
```

These configs are designed to be used together using [TypeScript's
support for extending multiple config
files](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#supporting-multiple-configuration-files-in-extends).

- tsconfig.base.json - This base config contains defaults that all
packages within the repo should use as a baseline.
- tsconfig.cjs.json - This config sets `module: Node16` and is intended
for CommonJS builds. This config is intended to
  be layered on top of the base config.
- tsconfig.esm.json - This config sets `module: ESNext` and
`moduleResolution: Node10` and is intended for ESM builds. This config
is intended to be layered on top of the base config. This config uses
Node10 module resolution because Node16 cannot be used to build both CJS
and ESM from a common source.
- tsconfig.test.json - This config disables some settings that we don't
want to use in test code, like `declaration` and `decarationMap`. It
also enables the `node` types by default.

This PR updates the packages in the packages/common and packages/dds
paths. For each package, the CJS, ESM, and test tsconfig files are
updated to use the new build-common configs, which means that CJS builds
now use module: node16 which implies moduleResolution: node16. ESNext
builds continue to use Node10 module resolution because Node16 cannot be
used to build both CJS and ESM from a common source.

azure/packages/azure-client/src/test/tsconfig.json

@@ -1,16 +1,17 @@
 {
-	"extends": "@fluidframework/build-common/ts-common-config.json",
-	"compilerOptions": {
-		"rootDir": "./",
-		"outDir": "../../dist/test",
-		"composite": true,
-		"types": ["mocha", "node"],
-		"skipLibCheck": true,
-	},
+	"extends": [
+		"../../../../../common/build/build-common/tsconfig.base.json",
+		"../../../../../common/build/build-common/tsconfig.test.json",
+	],
 	"include": ["./**/*"],
 	"references": [
 		{
 			"path": "../..",
 		},
 	],
+	"compilerOptions": {
+		"rootDir": "./",
+		"outDir": "../../dist/test",
+		"types": ["mocha", "node"],
+	},
 }

azure/packages/azure-client/tsconfig.esnext.json

@@ -1,7 +1,6 @@
 {
-	"extends": "./tsconfig.json",
+	"extends": ["./tsconfig.json", "../../../common/build/build-common/tsconfig.esm.json"],
 	"compilerOptions": {
 		"outDir": "./lib",
-		"module": "esnext",
 	},
 }

azure/packages/azure-client/tsconfig.json

@@ -1,11 +1,12 @@
 {
-	"extends": "@fluidframework/build-common/ts-common-config.json",
+	"extends": [
+		"../../../common/build/build-common/tsconfig.base.json",
+		"../../../common/build/build-common/tsconfig.cjs.json",
+	],
+	"include": ["src/**/*"],
+	"exclude": ["src/test/**/*"],
 	"compilerOptions": {
 		"rootDir": "./src",
 		"outDir": "./dist",
-		"composite": true,
-		"types": ["node"],
 	},
-	"include": ["src/**/*"],
-	"exclude": ["src/test/**/*"],
 }

azure/packages/azure-local-service/tsconfig.json

@@ -1,10 +1,12 @@
 {
-	"extends": "@fluidframework/build-common/ts-common-config.json",
-	"exclude": [],
+	"extends": [
+		"../../../common/build/build-common/tsconfig.base.json",
+		"../../../common/build/build-common/tsconfig.cjs.json",
+	],
+	"include": ["src/**/*"],
+	"exclude": ["src/test/**/*"],
 	"compilerOptions": {
 		"rootDir": "./src",
 		"outDir": "./dist",
-		"composite": true,
 	},
-	"include": ["src/**/*"],
 }

azure/packages/azure-service-utils/src/test/tsconfig.json

@@ -1,17 +1,18 @@
 {
-	"extends": "@fluidframework/build-common/ts-common-config.json",
-	"compilerOptions": {
-		"rootDir": "./",
-		"outDir": "../../dist/test",
-		"declaration": false,
-		"declarationMap": false,
-		"skipLibCheck": true,
-		"noEmit": true,
-	},
+	"extends": [
+		"../../../../../common/build/build-common/tsconfig.base.json",
+		"../../../../../common/build/build-common/tsconfig.test.json",
+	],
 	"include": ["./**/*"],
 	"references": [
 		{
 			"path": "../..",
 		},
 	],
+	"compilerOptions": {
+		"rootDir": "./",
+		"outDir": "../../dist/test",
+		"noEmit": true,
+		"types": [],
+	},
 }

azure/packages/azure-service-utils/tsconfig.esnext.json

@@ -1,7 +1,6 @@
 {
-	"extends": "./tsconfig.json",
+	"extends": ["./tsconfig.json", "../../../common/build/build-common/tsconfig.esm.json"],
 	"compilerOptions": {
 		"outDir": "./lib",
-		"module": "esnext",
 	},
 }

azure/packages/azure-service-utils/tsconfig.json

@@ -1,11 +1,12 @@
 {
-	"extends": "@fluidframework/build-common/ts-common-config.json",
+	"extends": [
+		"../../../common/build/build-common/tsconfig.base.json",
+		"../../../common/build/build-common/tsconfig.cjs.json",
+	],
+	"include": ["src/**/*"],
 	"exclude": ["src/test/**/*"],
 	"compilerOptions": {
-		"strictNullChecks": true,
 		"rootDir": "./src",
 		"outDir": "./dist",
-		"composite": true,
 	},
-	"include": ["src/**/*"],
 }

common/build/build-common/README.md

@@ -17,3 +17,24 @@ It can be extended in your package's local configuration file like the following
 
 This package previously exported a series of configurations with differing levels of validation.
 These configurations are now deprecated and have been replaced with the configuration noted above.
+
+## TypeScript Configurations (`tsconfig.json`)
+
+This package includes several TypeScript config (tsconfig) files that are contain the common configurations used within
+the Fluid Framework repo. These configs are designed to be used together using [TypeScript's support for extending
+multiple config
+files](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#supporting-multiple-configuration-files-in-extends).
+
+-   tsconfig.base.json - This base config contains defaults that all packages within the repo should use as a baseline.
+-   tsconfig.cjs.json - This config sets `module: Node16` and is intended for CommonJS builds. This config is intended to
+    be layered on top of the base config.
+-   tsconfig.esm.json - This config sets `module: ESNext` and `moduleResolution: Node10` and is intended for ESM builds. This config
+    intended to be layered on top of the base config. This config uses Node10 module resolution because Node16 cannot be
+    used to build both CJS and ESM from a common source.
+-   tsconfig.test.json - This config disables some settings that we don't want to use in test code, like `declaration` and
+    `decarationMap`. It also enables the `node` types by default.
+
+### Legacy tsconfig
+
+This package also contains a legacy base tsconfig, `ts-common-config.json`. This config is still used in some places
+within the repo but is considered deprecated.

common/build/build-common/tsconfig.base.json

@@ -6,6 +6,7 @@
 		"esModuleInterop": true,
 		"incremental": true,
 		"inlineSources": true,
+		"jsx": "react",
 		"lib": ["ES2020", "DOM", "DOM.Iterable"],
 		"noImplicitAny": false,
 		"noUnusedLocals": true,

common/build/build-common/tsconfig.cjs.json

@@ -1,5 +1,4 @@
 {
-	"extends": ["./tsconfig.base.json"],
 	"compilerOptions": {
 		"module": "Node16",
 	},

common/build/build-common/tsconfig.esm.json

@@ -1,5 +1,4 @@
 {
-	"extends": ["./tsconfig.base.json"],
 	"compilerOptions": {
 		"module": "ESNext",
 		"moduleResolution": "Node10",

common/build/build-common/tsconfig.test.json

@@ -1,10 +1,11 @@
 {
-	"extends": ["./tsconfig.esm.json"],
+	"extends": ["./tsconfig.base.json", "./tsconfig.esm.json"],
 	"compilerOptions": {
 		"composite": false,
 		"types": ["node"],
 		"declaration": false,
 		"declarationMap": false,
 		"skipLibCheck": true,
+		"module": "CommonJS",
 	},
 }

packages/common/client-utils/src/hashFileBrowser.ts

@@ -55,7 +55,7 @@ export async function hashFile(
 	if (crypto.subtle === undefined) {
 		return import(
 			/* webpackChunkName: "FluidFramework-HashFallback" */
-			"./hashFileNode"
+			"./hashFileNode.js"
 		).then(async (m) => m.hashFile(file, algorithm, hashEncoding));
 	}
 

packages/common/client-utils/src/test/jest/tsconfig.json

@@ -1,14 +1,17 @@
 {
-	"extends": "@fluidframework/build-common/ts-common-config.json",
-	"compilerOptions": {
-		"rootDir": "./",
-		"outDir": "../../../dist/test/jest",
-		"types": ["jest", "jest-environment-puppeteer", "node", "puppeteer"],
-	},
+	"extends": [
+		"../../../../../../common/build/build-common/tsconfig.base.json",
+		"../../../../../../common/build/build-common/tsconfig.test.json",
+	],
 	"include": ["./**/*"],
 	"references": [
 		{
 			"path": "../../..",
 		},
 	],
+	"compilerOptions": {
+		"rootDir": "./",
+		"outDir": "../../../dist/test/jest",
+		"types": ["jest", "jest-environment-puppeteer", "node", "puppeteer"],
+	},
 }

packages/common/client-utils/src/test/mocha/tsconfig.json

@@ -1,15 +1,17 @@
 {
-	"extends": "@fluidframework/build-common/ts-common-config.json",
-	"exclude": ["dist", "node_modules"],
-	"compilerOptions": {
-		"rootDir": "./",
-		"outDir": "../../../dist/test/mocha",
-		"types": ["node", "mocha"],
-	},
+	"extends": [
+		"../../../../../../common/build/build-common/tsconfig.base.json",
+		"../../../../../../common/build/build-common/tsconfig.test.json",
+	],
 	"include": ["./**/*"],
 	"references": [
 		{
 			"path": "../../..",
 		},
 	],
+	"compilerOptions": {
+		"rootDir": "./",
+		"outDir": "../../../dist/test/mocha",
+		"types": ["mocha", "node"],
+	},
 }

packages/common/client-utils/src/test/types/tsconfig.json

@@ -1,19 +1,21 @@
 {
-    "extends": "@fluidframework/build-common/ts-common-config.json",
+	"extends": [
+		"../../../../../../common/build/build-common/tsconfig.base.json",
+		"../../../../../../common/build/build-common/tsconfig.test.json",
+	],
+	"include": ["./**/*"],
     "exclude": [
         "dist",
         "node_modules"
     ],
-    "compilerOptions": {
-        "rootDir": "./",
-        "outDir": "../../../dist/test/types",
-    },
-    "include": [
-        "./**/*"
-    ],
-    "references": [
-        {
-            "path": "../../.."
-        }
-    ]
+	"references": [
+		{
+			"path": "../../..",
+		},
+	],
+	"compilerOptions": {
+		"rootDir": "./",
+    "outDir": "../../../dist/test/types",
+		"types": [],
+	},
 }

packages/common/client-utils/tsconfig.esnext.json

@@ -1,7 +1,6 @@
 {
-	"extends": "./tsconfig.json",
+	"extends": ["./tsconfig.json", "../../../common/build/build-common/tsconfig.esm.json"],
 	"compilerOptions": {
 		"outDir": "./lib",
-		"module": "esnext",
 	},
 }

packages/common/client-utils/tsconfig.json

@@ -1,15 +1,17 @@
 {
-	"extends": "@fluidframework/build-common/ts-common-config.json",
+	"extends": [
+		"../../../common/build/build-common/tsconfig.base.json",
+		"../../../common/build/build-common/tsconfig.cjs.json",
+	],
+	"include": ["src/**/*"],
+	"exclude": ["src/test/**/*"],
 	"compilerOptions": {
 		"rootDir": "./src",
 		"outDir": "./dist",
-		"composite": true,
 		"baseUrl": ".",
 		"paths": {
 			"perf_hooks": ["types/perf_hooks.d.ts"],
 		},
 		"types": ["events"],
 	},
-	"include": ["src/**/*"],
-	"exclude": ["src/test/**/*"],
 }

packages/common/container-definitions/src/test/types/tsconfig.json

@@ -1,19 +1,18 @@
 {
-    "extends": "@fluidframework/build-common/ts-common-config.json",
-    "compilerOptions": {
-        "rootDir": "./",
-        "outDir": "../../../dist/test/types",
-        "declaration": false,
-        "declarationMap": false,
-        "skipLibCheck": true,
-        "noEmit": true,
-    },
-    "include": [
-        "./**/*"
-    ],
-    "references": [
-        {
-            "path": "../../.."
-        }
-    ]
+	"extends": [
+		"../../../../../../common/build/build-common/tsconfig.base.json",
+		"../../../../../../common/build/build-common/tsconfig.test.json",
+	],
+	"include": ["./**/*"],
+	"references": [
+		{
+			"path": "../../..",
+		},
+	],
+	"compilerOptions": {
+		"rootDir": "./",
+		"outDir": "../../../dist/test/types",
+		"noEmit": true,
+		"types": [],
+	},
 }

packages/common/container-definitions/tsconfig.esnext.json

@@ -1,7 +1,6 @@
 {
-	"extends": "./tsconfig.json",
+	"extends": ["./tsconfig.json", "../../../common/build/build-common/tsconfig.esm.json"],
 	"compilerOptions": {
 		"outDir": "./lib",
-		"module": "esnext",
 	},
 }

packages/common/container-definitions/tsconfig.json

@@ -1,10 +1,12 @@
 {
-	"extends": "@fluidframework/build-common/ts-common-config.json",
+	"extends": [
+		"../../../common/build/build-common/tsconfig.base.json",
+		"../../../common/build/build-common/tsconfig.cjs.json",
+	],
+	"include": ["src/**/*"],
 	"exclude": ["src/test/**/*"],
 	"compilerOptions": {
 		"rootDir": "./src",
 		"outDir": "./dist",
-		"composite": true,
 	},
-	"include": ["src/**/*"],
 }

packages/common/core-interfaces/src/test/tsconfig.json

@@ -1,17 +1,16 @@
 {
-	"extends": "@fluidframework/build-common/ts-common-config.json",
-	"compilerOptions": {
-		"rootDir": "./",
-		"outDir": "../../dist/test",
-		"declaration": false,
-		"declarationMap": false,
-		"skipLibCheck": true,
-		"noEmit": true,
-	},
+	"extends": [
+		"../../../../../common/build/build-common/tsconfig.base.json",
+		"../../../../../common/build/build-common/tsconfig.test.json",
+	],
 	"include": ["./**/*"],
 	"references": [
 		{
 			"path": "../..",
 		},
 	],
+	"compilerOptions": {
+		"rootDir": "./",
+		"outDir": "../../dist/test",
+	},
 }